Make tab extension lazy #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me, thanks! Just kicked of CI to verify. |
djc
reviewed
Jan 15, 2025
| @@ -346,21 +347,20 @@ pub(crate) enum TabExpandedString { | |||
| NoTabs(Cow<'static, str>), | |||
| WithTabs { | |||
| original: Cow<'static, str>, | |||
| expanded: String, | |||
| expanded: OnceCell<String>, | |||
There was a problem hiding this comment.
Can we just use Option instead of OnceCell for this? Seems simpler.
There was a problem hiding this comment.
No, I don't think so: We don't have mut access in expanded. AFAIK, that's essentially what OnceCell is there for.
jaheba
force-pushed
the
lazy-tab-expansion
branch
from
e8de6a3 to
803b013
Compare
djc
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the snippet of #683 a big chunk of the time is spent in allocating a new string in
TabExpandedString. Delaying the expanding of tabs reduces the runtime of ~100ms to ~60ms.The idea is simple: Rather than replacing
\twith spaces immediately, this is done onceexpandedis actually called.