Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count 'Too Many Requests' as a retriable error #4902

Merged
merged 2 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ librdkafka v2.6.1 is a maintenance release:
zstd 1.5.6, zlib 1.3.1, OpenSSL 3.3.2, CURL 8.10.1 (#4872).
* SASL/SCRAM authentication fix: avoid concatenating
client side nonce once more, as it's already prepended in server sent nonce (#4895).
* Allow retrying for status code 429 ('Too Many Requests') in HTTP requests for
OAUTHBEARER OIDC (#4902).


## Fixes
Expand Down
1 change: 1 addition & 0 deletions src/rdhttp.c
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ static rd_bool_t rd_http_is_failure_temporary(int error_code) {
switch (error_code) {
case 408: /**< Request timeout */
case 425: /**< Too early */
case 429: /**< Too many requests */
case 500: /**< Internal server error */
case 502: /**< Bad gateway */
case 503: /**< Service unavailable */
Expand Down