Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin flexparser to <0.4 #71

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

ndevenish
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

See discussion in hgrecco/pint#1969 (comment)

The release of flexparser 0.4 has effectively "Backported" 😉 Python 3.13 failures to Python 3.12. This fixes the pinning for the current release and anyone pinning to this version of pint, this pin can be removed for the as-yet-unreleased next pint release.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 7, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • noarch: python recipes should almost always follow the syntax in our documentation. For the host section of the recipe, you should almost always use python {{ python_min }}.* for the python entry. You may need to override the python_min variable if the package requires a newer Python version than the currently supported minimum version on conda-forge.
  • noarch: python recipes should almost always follow the syntax in our documentation. For the run section of the recipe, you should almost always use python >={{ python_min }} for the python entry. You may need to override the python_min variable if the package requires a newer Python version than the currently supported minimum version on conda-forge.
  • noarch: python recipes should almost always follow the syntax in our documentation. For the test.requires section of the recipe, you should almost always use python ={{ python_min }} for the python entry. You may need to override the python_min variable if the package requires a newer Python version than the currently supported minimum version on conda-forge.

@ndevenish
Copy link
Contributor Author

I'm reluctant to address the new linting issues in this PR, suggest leaving for the imminent pint version update

@jan-janssen
Copy link
Member

@conda-forge-admin, please rerender

@jan-janssen jan-janssen added the automerge Merge the PR when CI passes label Nov 7, 2024
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run /~https://github.com/conda-forge/conda-forge-webservices/actions/runs/11721377498.

@ndevenish
Copy link
Contributor Author

Oh, this is slightly more complicated. This pint fails on 3.13 so needs to be restricted for build

@conda-forge-admin conda-forge-admin merged commit c0d4016 into conda-forge:main Nov 7, 2024
4 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@ndevenish
Copy link
Contributor Author

Ah, me being dumb. Your commit did that restriction but I hadn't refreshed github so the pass didn't show.

@ndevenish ndevenish deleted the fix_flexparser branch November 7, 2024 10:47
@stefdoerr
Copy link

stefdoerr commented Nov 7, 2024

Hi I see your fix on conda but conda install doesn't seem to pick it up. Is there some delay before the conda-forge indexes are updated?

The following package could not be installed
└─ pint ==0.24.3 pyhd8ed1ab_1 does not exist (perhaps a typo or a missing channel).

@jan-janssen
Copy link
Member

Yes, typically it takes about 30 minutes for the package to be available for download. It has something to do with the content delivery network anaconda is using.

@ndevenish
Copy link
Contributor Author

I've added a PR for older 0.24.* builds to conda-forge/conda-forge-repodata-patches-feedstock#900.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants