Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keras-* requirements #35

Closed
wants to merge 3 commits into from
Closed

Conversation

jjhelmus
Copy link
Contributor

@jjhelmus jjhelmus commented Oct 8, 2018

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jjhelmus
Copy link
Contributor Author

jjhelmus commented Oct 8, 2018

Requirements in the setup.py file:

numpy>=1.9.1
scipy>=0.14
six>=1.9.0
pyyaml
h5py
keras_applications>=1.0.6
keras_preprocessing>=1.0.5

@mariusvniekerk
Copy link
Member

@conda-forge-admin please rerender

@kyleabeauchamp
Copy link

What's the status of this PR? I think it might unblock conda-forge/tensorflow-feedstock#66 due to numpy pinning stuff.

@dhirschfeld
Copy link
Member

@conda-forge-admin please rerender

@dhirschfeld
Copy link
Member

Looks like it's failing on py37 but the error message doesn't appear to make much sense to me:

TEST START: C:\bld\win-64\keras-2.2.4-py37_1.tar.bz2
Adding in variants from C:\Users\appveyor\AppData\Local\Temp\1\tmpoh1k8b4m\info\recipe\conda_build_config.yaml
INFO:conda_build.variants:Adding in variants from C:\Users\appveyor\AppData\Local\Temp\1\tmpoh1k8b4m\info\recipe\conda_build_config.yaml
Renaming work directory,  C:\bld\keras_1551223013718\work  to  C:\bld\keras_1551223013718\work_moved_keras-2.2.4-py37_1_win-64
Collecting package metadata: ...working... done
Solving environment: ...working... failed
failed to get install actions, retrying.  exception was: Unsatisfiable dependencies for platform win-64: {'keras==2.2.4=py37_1'}
WARNING:conda_build.build:failed to get install actions, retrying.  exception was: Unsatisfiable dependencies for platform win-64: {'keras==2.2.4=py37_1'}
Tests failed for keras-2.2.4-py37_1.tar.bz2 - moving package to C:\bld\broken
WARNING:conda_build.build:Tests failed for keras-2.2.4-py37_1.tar.bz2 - moving package to C:\bld\broken
TESTS FAILED: keras-2.2.4-py37_1.tar.bz2

@mariusvniekerk
Copy link
Member

That generally means some dependency is missing for py37

@kyleabeauchamp
Copy link

kyleabeauchamp commented Feb 26, 2019

I definitely saw some strange keras-numpy-TF pinning / requirement issues over in conda-forge/tensorflow-feedstock#66; I only saw issues on windows, though, so I skipped windows on that PR to get things green.

Seems like stuff is busted here on linux as well, though, so my experience won't be it...

@dhirschfeld
Copy link
Member

dhirschfeld commented Feb 26, 2019

Yeah, I figured but AFAICS the error message only lists the package itself rather than the missing dependency which isn't very helpful :(

I thought newer conda was supposed to have better error messages than that. It does look like the CI is running the latest 4.6.7 though

@jjhelmus
Copy link
Contributor Author

closing in favor of #37

@jjhelmus jjhelmus closed this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants