Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosquitto: add version 2.0.20 #26721

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dietssa
Copy link
Contributor

@dietssa dietssa commented Feb 28, 2025

Summary

Changes to recipe: mosquitto/2.0.20

Motivation

There are several bug and security fixes in 2.0.19 and 2.0.20.

Details


@CLAassistant
Copy link

CLAassistant commented Feb 28, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jcar87
Copy link
Contributor

jcar87 commented Feb 28, 2025

Thanks @dietssa ! Please remember to add the version to config.yml as well :)

@dietssa
Copy link
Contributor Author

dietssa commented Feb 28, 2025

Thanks @dietssa ! Please remember to add the version to config.yml as well :)

Oops, thanks @jcar87 for having a look!
I added the version in config.yml now.

@dietssa
Copy link
Contributor Author

dietssa commented Feb 28, 2025

The Windows build fail seems to be related to the following change:

  • Thread support is re-enabled on Windows.

in https://mosquitto.org/blog/2024/10/version-2-0-19-released/.

The mosquitto commit is this one:
eclipse-mosquitto/mosquitto@a3e5deb#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a

Looks like the commit adds a dependency to pthreads4w: https://conan.io/center/recipes/pthreads4w.

I try to get this working with a local windows build.

@jcar87
Copy link
Contributor

jcar87 commented Feb 28, 2025

I try to get this working with a local windows build.

If you are able to troubleshoot this and address this, that would be hugely appreciated!

It seems there's an issue with the CLA as well - can happen when the git history of the PR branch has commits from different authors (or authors with different emails)

@dietssa
Copy link
Contributor Author

dietssa commented Feb 28, 2025

If you are able to troubleshoot this and address this, that would be hugely appreciated!

Sure!

Turns out the Windows build issue is a known issue in the mosquitto project, here:
eclipse-mosquitto/mosquitto#3139
It is already fixed on master, and should be released as new bugfix version 2.0.21 "this week":
eclipse-mosquitto/mosquitto#3139 (comment)

I would update the PR here then as soon as the mosquitto release is available, hopefully next week.

@jcar87
Copy link
Contributor

jcar87 commented Feb 28, 2025

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants