[OPIK-1020] feedback score reason #1403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadereiko
requested changes
Feb 27, 2025
There was a problem hiding this comment.
Good work, some small improvements in the code are listed.
- Maybe, we should add reasons to Experiment Item Sidebar as well
- It's weirdly bouncing when you edit an already existing reason, stop typing - it updates the state - and the reason icon dissapears and appears again. So, maybe we could avoid having it - caching the previous state
| @@ -119,3 +119,17 @@ export const extractIdFromLocation = (location: string) => | |||
|
|
|||
| export const formatNumericData = (value: number, precision = 3) => | |||
| String(round(value, precision)); | |||
|
|
|||
| export const updateTextAreaHeight = ( | |||
There was a problem hiding this comment.
it doesn't have to be specifically textArea in this function, any html element would fit. however, as we're using it only for textAreas, it's ok to keep it now
Comment on lines
38
to
41
| return { | ||
| value: inputValue, | ||
| onChange: handleInputChange, | ||
| }; |
There was a problem hiding this comment.
as an idea, I like that sometimes in libraries they return [value, onChange]. So, a person could you use it as const [debouncedValue, debouncedChangeValue] = useDebouncedValue({ ... }). your solution is good as well :)
...end/src/components/pages-shared/traces/TraceDetailsPanel/TraceAnnotateViewer/AnnotateRow.tsx
Outdated
Show resolved
Hide resolved
...end/src/components/pages-shared/traces/TraceDetailsPanel/TraceAnnotateViewer/AnnotateRow.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
Resolves #
Testing
Documentation