-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for another cds spans edge case #198
Conversation
Reviewer's Guide by SourceryThis pull request addresses an edge case in the handling of CDS spans for single-exon transcripts. The code now correctly adjusts the CDS spans by limiting the cds_spans array to the first element when processing single-exon transcripts. Sequence diagram for CDS span adjustment in single-exon transcriptssequenceDiagram
participant MT as _mysql_core_attr.py
participant lex
participant cds_spans
MT->>cds_spans: cds_spans[start_index : start_index + 1]
MT->>lex: _adjust_single_exon(lex, cds_spans[0])
MT->>MT: yield TranscriptAttrRecord(...)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GavinHuttley - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's good to see a specific edge case being addressed, but please include details of the bug in the description.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Pull Request Test Coverage Report for Build 13561833520Details
💛 - Coveralls |
Summary by Sourcery
Bug Fixes: