-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: code tidy #197
MAINT: code tidy #197
Conversation
Reviewer's Guide by SourceryThis pull request focuses on code tidying. It removes commented-out code, updates type hints for better clarity, and refactors an assertion in a test for improved readability. Updated class diagram for TranscriptSpanclassDiagram
class TranscriptSpan {
transcript_spans: np.ndarray
cds_spans: np.ndarray
exon_spans: np.ndarray
start() int
stop() int
to_record(columns: tuple[str, ...]) tuple
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GavinHuttley - I've reviewed your changes - here's some feedback:
Overall Comments:
- The change to
to_record
'scolumns
argument should include a type annotation change in the function signature.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Pull Request Test Coverage Report for Build 13558106124Details
💛 - Coveralls |
Summary by Sourcery
This PR performs minor code tidying, including removing unused code and standardising type annotations.