-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: allow specifying the directory for creating tmpdir #180
Conversation
Reviewer's Guide by SourceryThis pull request introduces a change to the Sequence diagram for temporary directory creation with custom working directorysequenceDiagram
participant C as Client Code
participant T as tempdir()
participant S as System temp
C->>+T: Create temp dir(working_dir)
alt working_dir specified
T->>S: Create temp dir in working_dir
else working_dir not specified
T->>S: Create temp dir in system default
end
T-->>-C: Return Path object
Note over C,T: Use temp dir
C->>T: Exit context
T->>S: Clean up temp dir
Class diagram showing tempdir function modificationclassDiagram
class tempdir{
+__enter__(working_dir: Optional[Path|str]) Path
+__exit__()
}
note for tempdir "Modified to accept working_dir parameter"
class Path{
+cwd() Path
}
tempdir ..> Path: uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GavinHuttley - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider making the temp directory location configurable rather than hardcoding CWD in _ingest_annotation.py
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Pull Request Test Coverage Report for Build 12859953874Details
💛 - Coveralls |
Summary by Sourcery
Enhancements:
working_dir
parameter to thetempdir
context manager to create the temporary directory in the specified location.