Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large content performance #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Large content performance #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4fb2bf
Unpickle context only from `phased` blocks
jkuczm Sep 14, 2013
af265c8
Comments to improve second_pass_render() clarity.
philipn Aug 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions phased/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,18 @@ def second_pass_render(request, content):
result = tokens = []
for index, bit in enumerate(content.split(settings.PHASED_SECRET_DELIMITER)):
if index % 2:
# We split(), so every other index is a phased content block:
tokens = Lexer(bit, None).tokenize()
context = RequestContext(request,
restore_csrf_token(request, unpickle_context(bit)))
else:
tokens.append(Token(TOKEN_TEXT, bit))
# We're not in a phased content block, so don't bother restoring context:
tokens = [Token(TOKEN_TEXT, bit)]
context = None

context = RequestContext(request,
restore_csrf_token(request, unpickle_context(bit)))
rendered = Parser(tokens).parse().render(context)

# Phased blocks can contain phased blocks.
if settings.PHASED_SECRET_DELIMITER in rendered:
rendered = second_pass_render(request, rendered)
result.append(rendered)
Expand Down