Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use npm command to find bin path #16

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Use npm command to find bin path #16

merged 2 commits into from
Mar 9, 2022

Conversation

kayhide
Copy link
Contributor

@kayhide kayhide commented Oct 27, 2019

As suggested on #15, this implements npm bin version.

Close #15

@codesuki
Copy link
Owner

Thanks for the PR! I'll review it.

@codesuki
Copy link
Owner

codesuki commented Mar 9, 2022

Sorry, I totally lost track of this.

@codesuki codesuki merged commit d8bd55d into codesuki:master Mar 9, 2022
@jletourneau jletourneau mentioned this pull request Mar 12, 2022
Closed
@kayhide
Copy link
Contributor Author

kayhide commented Mar 15, 2022

Oh, yeah, finally.
Thanks for accepting the PR!

@codesuki
Copy link
Owner

Thanks for sending it and sorry for taking so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is this method insecure and, if yes, can we use npm bin ?
2 participants
@kayhide @codesuki