Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention that we don't support Advisory Lock Functions #18154

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

yuzefovich
Copy link
Member

We defined some builtins around pg_advisory locks, but they are no-ops, and some functions are not even defined. This commit adds this limitation to unsupported postgres features.

See cockroachdb/cockroach#13546.

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 0377710
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/657b36e47617f9000827bbeb

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 0377710
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/657b36e4d217270008708216

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for cockroachdb-docs canceled.

Name Link
🔨 Latest commit 0377710
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/657b36e48ca0da000881994d

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Yahor!

@yuzefovich
Copy link
Member Author

Thanks for the review!

We defined some builtins around pg_advisory locks, but they are no-ops,
and some functions are not even defined. This commit adds this
limitation to unsupported postgres features.

See cockroachdb/cockroach#13546.
@yuzefovich yuzefovich merged commit 6d9af1f into main Dec 14, 2023
6 checks passed
@yuzefovich yuzefovich deleted the advisory-locks branch December 14, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants