sql: implement pg_extension virtual table

CockroachDB doesn't support extensions, so this is an empty table. It's needed for ORM support.
cockroachdb · Feb 7, 2017 · 3a1bae1 · 3a1bae1
1 parent 4d19c56
commit 3a1bae1
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 0 deletions.
diff --git a/pkg/sql/pg_catalog.go b/pkg/sql/pg_catalog.go
@@ -61,6 +61,7 @@ var pgCatalog = virtualSchema{
 		pgCatalogDependTable,
 		pgCatalogDescriptionTable,
 		pgCatalogEnumTable,
+		pgCatalogExtensionTable,
 		pgCatalogForeignServerTable,
 		pgCatalogForeignTableTable,
 		pgCatalogIndexTable,
@@ -746,6 +747,25 @@ CREATE TABLE pg_catalog.pg_enum (
 	},
 }
 
+// See: https://www.postgresql.org/docs/9.6/static/catalog-pg-extension.html.
+var pgCatalogExtensionTable = virtualSchemaTable{
+	schema: `
+CREATE TABLE pg_catalog.pg_extension (
+  extname NAME,
+  extowner OID,
+  extnamespace OID,
+  extrelocatable BOOL,
+  extversion STRING,
+  extconfig STRING,
+  extcondition STRING
+);
+`,
+	populate: func(p *planner, addRow func(...parser.Datum) error) error {
+		// Extensions are not supported.
+		return nil
+	},
+}
+
 // See: https://www.postgresql.org/docs/9.6/static/catalog-pg-foreign-server.html.
 var pgCatalogForeignServerTable = virtualSchemaTable{
 	schema: `

diff --git a/pkg/sql/testdata/information_schema b/pkg/sql/testdata/information_schema
@@ -225,6 +225,7 @@ pg_database
 pg_depend
 pg_description
 pg_enum
+pg_extension
 pg_foreign_server
 pg_foreign_table
 pg_index
@@ -275,6 +276,7 @@ pg_indexes
 pg_index
 pg_foreign_table
 pg_foreign_server
+pg_extension
 pg_enum
 pg_description
 pg_depend
@@ -312,6 +314,7 @@ def            pg_catalog          pg_database        SYSTEM VIEW  1
 def            pg_catalog          pg_depend          SYSTEM VIEW  1
 def            pg_catalog          pg_description     SYSTEM VIEW  1
 def            pg_catalog          pg_enum            SYSTEM VIEW  1
+def            pg_catalog          pg_extension       SYSTEM VIEW  1
 def            pg_catalog          pg_foreign_server  SYSTEM VIEW  1
 def            pg_catalog          pg_foreign_table   SYSTEM VIEW  1
 def            pg_catalog          pg_index           SYSTEM VIEW  1
@@ -369,6 +372,7 @@ def            pg_catalog          pg_database        SYSTEM VIEW  1
 def            pg_catalog          pg_depend          SYSTEM VIEW  1
 def            pg_catalog          pg_description     SYSTEM VIEW  1
 def            pg_catalog          pg_enum            SYSTEM VIEW  1
+def            pg_catalog          pg_extension       SYSTEM VIEW  1
 def            pg_catalog          pg_foreign_server  SYSTEM VIEW  1
 def            pg_catalog          pg_foreign_table   SYSTEM VIEW  1
 def            pg_catalog          pg_index           SYSTEM VIEW  1
@@ -417,6 +421,7 @@ def            pg_catalog          pg_database        SYSTEM VIEW  1
 def            pg_catalog          pg_depend          SYSTEM VIEW  1
 def            pg_catalog          pg_description     SYSTEM VIEW  1
 def            pg_catalog          pg_enum            SYSTEM VIEW  1
+def            pg_catalog          pg_extension       SYSTEM VIEW  1
 def            pg_catalog          pg_foreign_server  SYSTEM VIEW  1
 def            pg_catalog          pg_foreign_table   SYSTEM VIEW  1
 def            pg_catalog          pg_index           SYSTEM VIEW  1

diff --git a/pkg/sql/testdata/pg_catalog b/pkg/sql/testdata/pg_catalog
@@ -54,6 +54,7 @@ pg_database
 pg_depend
 pg_description
 pg_enum
+pg_extension
 pg_foreign_server
 pg_foreign_table
 pg_index
@@ -894,6 +895,12 @@ SELECT * FROM pg_catalog.pg_enum
 ----
 oid  enumtypid  enumsortorder  enumlabel
 
+## pg_catalog.pg_extension
+query TOOBTTT colnames
+SELECT * FROM pg_catalog.pg_extension
+----
+extname  extowner  extnamespace  extrelocatable  extversion  extconfig  extcondition
+
 ## pg_catalog.pg_settings
 
 query TTTTTT colnames