Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(executor): remove {byte,short,char,bool} from {Stack,LocalVars} #106

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix(executor): remove {byte,short,char,bool} from {Stack,LocalVars} #106

merged 1 commit into from
Jan 10, 2024

Conversation

liketechnik
Copy link
Contributor

fixes #105

@liketechnik
fix(executor): remove {byte,short,char,bool} from {Stack,LocalVars}
6e5c86d 
Since the JVM OpCodes contains only operators on int,
these types are more or less unused anyway.
Removing them simplifies the implementation,
since now the decision if {byte,short,char,bool} variants need
to be considered to when accessing {Stack,Var} values.
@liketechnik liketechnik requested a review from a team January 10, 2024 07:39
@Kerreytsugo Kerreytsugo merged commit dce13c0 into main Jan 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerreytsugo Kerreytsugo Kerreytsugo approved these changes

Assignees
No one assigned
Labels
kind::bug priority::high status::acceptance test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[executor] check where computational int conversions are needed
2 participants
@liketechnik @Kerreytsugo