Skip to content

Commit

Permalink
Let developers without VS installed test build scripts
Browse files Browse the repository at this point in the history 
Developers can test the build process without needing to recompile a new
launcher exe. This saves some setup steps to get a new developer started.

Also warn that this build can't be release as by definition it can't be
fully tested.
  • Loading branch information
@Jackbennett
Jackbennett committed Oct 14, 2015
1 parent 0051614 commit 2724099
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions scripts/build.ps1
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ Param(
[string]$config = "..\config",

# Include git with the package build
[switch]$Full
[switch]$Full,

# New launcher if you have MSBuild tools installed
[switch]$Compile
)

. "$PSScriptRoot\utils.ps1"
Expand Down Expand Up @@ -105,8 +108,13 @@ if ($ConEmuXml -ne "") {

Pop-Location

Push-Location -Path $launcher
msbuild CmderLauncher.vcxproj /p:configuration=Release
Pop-Location
if($Compile) {
Push-Location -Path $launcher
msbuild CmderLauncher.vcxproj /p:configuration=Release
Pop-Location
} else {
Write-Warning "You are not building a launcher, Use -Complie"

This comment has been minimized.

Sign in to view

Copy link
@Stanzilla

Stanzilla Oct 14, 2015

Member

typo
Write-Warning "This cannot be a release. Test build only!"
}

Write-Verbose "All good and done!"

5 comments on commit 2724099

@Stanzilla
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need the Full switch? I mean we never do releases that don't have Full anyway and Full generates the _mini part, too?

@Jackbennett
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably take it out. You would run this twice for full and minimal but the pack script makes both. Now it just makes testing faster so you don't wait for the massive git download. Could probably just supply a custom sources file to do that.

@Stanzilla
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always think negative flags are better, as in -nocompile and -nogit would be better since the default will always be without those flags

@Jackbennett
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too but what are defaults for if not the first-run experience?

@Stanzilla
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand what you mean. The script is mainly used by us, to prepare a release. And our default use case is always a full release, so that would be the baseline, no?

Please sign in to comment.