Skip to content

Commit

Permalink
bug KnpLabs#979 Deployments: use proper media-type for in_progress/qu…
Browse files Browse the repository at this point in the history
…eued, inactive state (staabm)

This PR was squashed before being merged into the 3.1.x-dev branch.

Discussion
----------

closes KnpLabs#978

Commits
-------

5ffefdc Deployments: use correct media-type for in_progress/queued, inactive
bf3eb1f Update Deployment.php
ca128f6 cs
  • Loading branch information
staabm authored and clxmstaab committed Mar 26, 2021
1 parent 90e695e commit 0c2815f
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions lib/Github/Api/Deployment.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
*/
class Deployment extends AbstractApi
{
use AcceptHeaderTrait;

/**
* List deployments for a particular repository.
*
Expand Down Expand Up @@ -88,6 +90,15 @@ public function updateStatus($username, $repository, $id, array $params)
throw new MissingArgumentException(['state']);
}

// adjust media-type per github docs
// https://docs.github.com/en/rest/reference/repos#create-a-deployment-status
if ($params['state'] === 'inactive') {
$this->acceptHeaderValue = 'application/vnd.github.ant-man-preview+json';
}
if ($params['state'] === 'in_progress' || $params['state'] === 'queued') {
$this->acceptHeaderValue = 'application/vnd.github.flash-preview+json';
}

return $this->post('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/deployments/'.$id.'/statuses', $params);
}

Expand Down

0 comments on commit 0c2815f

Please sign in to comment.