Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nodejs_compat by default for new projects created by C3 #8310

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Enable nodejs_compat by default for new projects created by C3 #8310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c94e80e
Enable nodejs_compat by default in C3 templates
irvinebroque Feb 28, 2025
a479da7
add changeset
irvinebroque Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sharp-cheetahs-perform.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-cloudflare": patch
---

Enable nodejs_compat by default for templates generated by C3
2 changes: 1 addition & 1 deletion fixtures/vitest-pool-workers-examples/basics-integration-auxiliary/wrangler.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
name = "basics-integration-auxiliary"
main = "src/index.ts"
compatibility_date = "2024-01-01"
compatibility_date = "2024-01-01"
1 change: 1 addition & 0 deletions ...create-cloudflare/templates-experimental/hello-world-assets-only/templates/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "<TBD>",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"assets": {
"directory": "./public"
},
Expand Down
1 change: 1 addition & 0 deletions ...loudflare/templates-experimental/hello-world-durable-object-with-assets/js/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.js",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"assets": {
"binding": "ASSETS",
"directory": "./public"
Expand Down
1 change: 1 addition & 0 deletions ...loudflare/templates-experimental/hello-world-durable-object-with-assets/ts/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.ts",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"migrations": [
{
"new_classes": [
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates-experimental/hono/templates/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.ts",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"assets": {
"binding": "ASSETS",
"directory": "./public"
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates-experimental/nuxt/templates/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "./.output/server/index.mjs",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"assets": {
"binding": "ASSETS",
"directory": "./.output/public/"
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates-experimental/remix/templates/wrangler.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#:schema node_modules/wrangler/config-schema.json
name = "<TBD>"
compatibility_date = "<TBD>"
compatibility_flags = ["nodejs_compat"]
main = "./server.ts"
assets = { directory = "./build/client" }

Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates-experimental/svelte/templates/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": ".svelte-kit/cloudflare/_worker.js",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"assets": {
"binding": "ASSETS",
"directory": ".svelte-kit/cloudflare"
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates-experimental/vue/templates/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "<TBD>",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"assets": {
"directory": "./dist"
},
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/hello-world-durable-object/js/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.js",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"migrations": [
{
"new_classes": [
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/hello-world-durable-object/ts/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.ts",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"migrations": [
{
"new_classes": [
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/hello-world/js/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.js",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"observability": {
"enabled": true,
},
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/hello-world/ts/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.ts",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"observability": {
"enabled": true,
},
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/hono/templates/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.ts",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"observability": {
"enabled": true
}
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/openapi/ts/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.ts",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"observability": {
"enabled": true
}
Expand Down
6 changes: 6 additions & 0 deletions packages/create-cloudflare/templates/pre-existing/js/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "<TBD>",
"main": "src/index.js",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"]
}
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/queues/js/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.js",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"observability": {
"enabled": true
},
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/queues/ts/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.ts",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"observability": {
"enabled": true
},
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/remix/templates/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"name": "<TBD>",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"pages_build_output_dir": "./build/client"
}
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/scheduled/js/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.js",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"observability": {
"enabled": true
},
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/scheduled/ts/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "<TBD>",
"main": "src/index.ts",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"observability": {
"enabled": true
},
Expand Down
1 change: 1 addition & 0 deletions packages/create-cloudflare/templates/svelte/templates/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"name": "<TBD>",
"compatibility_date": "<TBD>",
"compatibility_flags": ["nodejs_compat"],
"pages_build_output_dir": ".svelte-kit/cloudflare"
}
Loading