-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: interactively list Cloudchamber deployments using labels #8201
fix: interactively list Cloudchamber deployments using labels #8201
Conversation
@@ -87,7 +88,8 @@ export async function loadDeployments( | |||
deploymentsParams?.location, | |||
deploymentsParams?.image, | |||
deploymentsParams?.state as DeploymentPlacementState | undefined, | |||
deploymentsParams?.state | |||
deploymentsParams?.state, | |||
deploymentsParams?.labels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this codepath not covered by any tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I believe the interactive flows are not covered by any of the existing tests.
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-wrangler-8201 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8201/npm-package-wrangler-8201 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-wrangler-8201 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-workers-bindings-extension-8201 -O ./cloudflare-workers-bindings-extension.0.0.0-vc2fb95d0d.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vc2fb95d0d.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-create-cloudflare-8201 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-kv-asset-handler-8201 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-miniflare-8201 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-pages-shared-8201 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-unenv-preset-8201 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-vite-plugin-8201 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-vitest-pool-workers-8201 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-workers-editor-shared-8201 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-workers-shared-8201 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-workflows-shared-8201 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that in the tests there was already a TODO to add interactive tests.
See
workers-sdk/packages/wrangler/src/__tests__/cloudchamber/list.test.ts
Lines 70 to 71 in 26a66d7
// so testing the actual UI will be harder than expected | |
// TODO: think better on how to test UI actions |
Given the lack of any tests, and that this is a pretty small addition which matches the typings of the API call, I think we can land this.
b3398de
to
5a4485a
Compare
🦋 Changeset detectedLatest commit: a11dfea The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The `--label` arguments were ignored when listing deployments interactively.
5a4485a
to
a11dfea
Compare
Congratulations @ichernetsky-cf, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm7oyvy4r99240cl1hbha8nwz This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
The
--label
arguments were ignored when listing deployments interactively.