Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interactively list Cloudchamber deployments using labels #8201

Conversation

ichernetsky-cf
Copy link
Contributor

@ichernetsky-cf ichernetsky-cf commented Feb 19, 2025

The --label arguments were ignored when listing deployments interactively.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no test coverage of interactive flow
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not a documented aspect of the feature

@ichernetsky-cf ichernetsky-cf requested review from a team as code owners February 19, 2025 23:46
@skepticfx skepticfx self-requested a review February 20, 2025 00:55
@@ -87,7 +88,8 @@ export async function loadDeployments(
deploymentsParams?.location,
deploymentsParams?.image,
deploymentsParams?.state as DeploymentPlacementState | undefined,
deploymentsParams?.state
deploymentsParams?.state,
deploymentsParams?.labels
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this codepath not covered by any tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I believe the interactive flows are not covered by any of the existing tests.

@CarmenPopoviciu CarmenPopoviciu added the awaiting reporter response Needs clarification or followup from OP label Feb 25, 2025
Copy link
Contributor

github-actions bot commented Feb 25, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-wrangler-8201

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8201/npm-package-wrangler-8201

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-wrangler-8201 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-workers-bindings-extension-8201 -O ./cloudflare-workers-bindings-extension.0.0.0-vc2fb95d0d.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vc2fb95d0d.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-create-cloudflare-8201 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-kv-asset-handler-8201

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-miniflare-8201

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-pages-shared-8201

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-unenv-preset-8201

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-vite-plugin-8201

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-vitest-pool-workers-8201

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-workers-editor-shared-8201

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-workers-shared-8201

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13586873980/npm-package-cloudflare-workflows-shared-8201

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.111.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.1
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin removed the awaiting reporter response Needs clarification or followup from OP label Feb 27, 2025
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that in the tests there was already a TODO to add interactive tests.
See

// so testing the actual UI will be harder than expected
// TODO: think better on how to test UI actions

Given the lack of any tests, and that this is a pretty small addition which matches the typings of the API call, I think we can land this.

@petebacondarwin petebacondarwin force-pushed the ichernetsky/cc-list-deployments-by-labels branch from b3398de to 5a4485a Compare February 27, 2025 17:17
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: a11dfea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

The `--label` arguments were ignored when listing deployments
interactively.
@petebacondarwin petebacondarwin force-pushed the ichernetsky/cc-list-deployments-by-labels branch from 5a4485a to a11dfea Compare February 28, 2025 11:07
@petebacondarwin petebacondarwin added the e2e Run wrangler e2e tests on a PR label Feb 28, 2025
@petebacondarwin petebacondarwin merged commit 2cad136 into cloudflare:main Feb 28, 2025
21 of 22 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Feb 28, 2025
Copy link

holopin-bot bot commented Feb 28, 2025

Congratulations @ichernetsky-cf, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm7oyvy4r99240cl1hbha8nwz

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run wrangler e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants