Create a new major version of the MQTT package, to adopt MQTTnet v4.x #295
Conversation
RELEASING.md
Outdated
|
|
||
| A single GitHub release (and tag) will be created for each beta release, to cover all packages. | ||
|
|
||
| - Example tag name: "CloudNative.CloudEvents.All-2.0.0" | ||
| - Example release title: "All packages version 2.0.0" | ||
|
|
||
| ### Exception: new major versions | ||
|
|
||
| Sometimes, we need a new major version of a "satellite" package, typically |
There was a problem hiding this comment.
| Sometimes, we need a new major version of a "satellite" package, typically | |
| Usually, all packages shipped from this repo share the same major version. Sometimes, we need a new major version of a "satellite" package, typically |
There was a problem hiding this comment.
Hmm... I think I'll reword again. (Because it's a "usually in the sense of most packages" rather than a "usually in the sense of most releases".) Thanks for pointing out that it needs tweaking :)
There was a problem hiding this comment.
I've reworded this whole paragraph and added the specific MQTT example (in the past tense, to avoid having to update it again after the release I expect to do as soon as this is in).
There was a problem hiding this comment.
Rewording looks good! I mostly wanted to make sure we documented that a different major version was the exception, not the norm, with our current versioning strategy. I think your latest delta conveys that sufficiently.
There was a problem hiding this comment.
Thanks! I really appreciate the attention to detail :) Will merge now, then create a release PR (possibly tomorrow).
jskeet
force-pushed
the
mqtt-major
branch
3 times, most recently
from
85e9414 to
e9cd37b
Compare
This more fine-grained way of referring to the versions will allow us to still only change Directory.Build.props just before a release, but have separate major versions flow from that. Signed-off-by: Jon Skeet <jonskeet@google.com>
This involves a new major version of CloudNative.CloudEvents.Mqtt. Signed-off-by: Jon Skeet <jonskeet@google.com>
Fixes #269.
cc @captainsafia, @antiblue, @Clockwork-Muse
This PR doesn't create the new release - I'd do that in a separate (tiny) PR.