Code

Pasting image widget into table cell#694

Code

Merged

f1ames merged 45 commits intomasterckeditor/ckeditor4:masterfrom t/520ckeditor/ckeditor4:t/520Copy head branch name to clipboardAug 10, 2017

+849-215

Commits

Commits on Aug 10, 2017

• unit test for pasting image2 widget to table with tableselect plugin

  

  wojtekw92

  authored and

  f1ames

  committed
  2e16b06

  Copy full SHA for 2e16b06

• whitespace fixes

  

  wojtekw92

  authored and

  f1ames

  committed
  6345724

  Copy full SHA for 6345724

• Update unit test.

  

  Comandeer

  authored and

  f1ames

  committed
  6cd7e32

  Copy full SHA for 6cd7e32

• Add manual test.

  

  Comandeer

  authored and

  f1ames

  committed
  a1b9f09

  Copy full SHA for a1b9f09

• Move evt.stop after all early returns.

  

  Comandeer

  authored and

  f1ames

  committed
  2e914c3

  Copy full SHA for 2e914c3

• Pass pasting to other paste handlers.

  

  Comandeer

  authored and

  f1ames

  committed
  a9a03f0

  Copy full SHA for a9a03f0

• Add undo integration tests.

  

  Comandeer

  authored and

  f1ames

  committed
  5b046cd

  Copy full SHA for 5b046cd

• Introduce emptyCells function.

  

  Comandeer

  authored and

  f1ames

  committed
  84eaa5c

  Copy full SHA for 84eaa5c

• Update unit tests.

  

  Comandeer

  authored and

  f1ames

  committed
  a6230f3

  Copy full SHA for a6230f3

• Select cells after paste.

  

  Comandeer

  authored and

  f1ames

  committed
  636e816

  Copy full SHA for 636e816

• Move assertion to afterPaste event listener.

  

  Comandeer

  authored and

  f1ames

  committed
  797b10a

  Copy full SHA for 797b10a

• Add paste flow test case for non-tabular content.

  

  Comandeer

  authored and

  f1ames

  committed
  aa6f3e0

  Copy full SHA for aa6f3e0

• Refactoring: tabletools.getSelectedCells() return an empty array if no selection is given.

  Show description for 61cf773
  

  mlewand

  authored and

  f1ames

  committed
  61cf773

  Copy full SHA for 61cf773

• Refactoring: paste listener simplified.

  

  mlewand

  authored and

  f1ames

  committed
  90d437a

  Copy full SHA for 90d437a

• Refactoring: extracted some logic from boundary case handling.

  

  mlewand

  authored and

  f1ames

  committed
  723f0ad

  Copy full SHA for 723f0ad

• Refactoring: extracted function responsible for parsing pasted content.

  

  mlewand

  authored and

  f1ames

  committed
  ffb1c13

  Copy full SHA for ffb1c13

• Updated the comment according to my review suggestion.

  

  mlewand

  authored and

  f1ames

  committed
  b118d86

  Copy full SHA for b118d86

• Minor refactorization.

  

  mlewand

  authored and

  f1ames

  committed
  9c79445

  Copy full SHA for 9c79445

• Added a remark about further simplification possibility.

  

  mlewand

  authored and

  f1ames

  committed
  cc3f3fb

  Copy full SHA for cc3f3fb

• Fixed failing tests, improved condition catching cases which should not be customized by table selection.

  

  mlewand

  authored and

  f1ames

  committed
  79c1b1d

  Copy full SHA for 79c1b1d

• Tabletools insertRow / insertColumn will now return added elements.

  

  mlewand

  authored and

  f1ames

  committed
  00ce5ef

  Copy full SHA for 00ce5ef

• Introduced TableSelection type.

  Show description for 3a800f7
  

  mlewand

  authored and

  f1ames

  committed
  3a800f7

  Copy full SHA for 3a800f7

• Refactoring: further simplification in preparation to extract paste table DOM manipulation logic.

  

  mlewand

  authored and

  f1ames

  committed
  5870f90

  Copy full SHA for 5870f90

• Refactoring: extracted pasteTable method.

  

  mlewand

  authored and

  f1ames

  committed
  f58d4d2

  Copy full SHA for f58d4d2

• Refactoring: further simplifications.

  

  mlewand

  authored and

  f1ames

  committed
  d52f17e

  Copy full SHA for d52f17e

• Added a function that will reorder selected cells according to DOM position.

  

  mlewand

  authored and

  f1ames

  committed
  4be8747

  Copy full SHA for 4be8747

• Added some API docs.

  

  mlewand

  authored and

  f1ames

  committed
  b23b4a8

  Copy full SHA for b23b4a8

• Fixed outdated cells passed to insertColumn / insertRow.

  Show description for 825c6fa
  

  mlewand

  authored and

  f1ames

  committed
  825c6fa

  Copy full SHA for 825c6fa

• Fixed an edge case when inserting rows.

  

  mlewand

  authored and

  f1ames

  committed
  f127170

  Copy full SHA for f127170

• Fixed a case when pasting into a partially selected cell would be customized by tableselection.

  Show description for c6484e8
  

  mlewand

  authored and

  f1ames

  committed
  c6484e8

  Copy full SHA for c6484e8

• Refactoring: minor adjustments.

  

  mlewand

  authored and

  f1ames

  committed
  d2c0312

  Copy full SHA for d2c0312

• Refactoring: renamed paste listener.

  

  mlewand

  authored and

  f1ames

  committed
  037d80c

  Copy full SHA for 037d80c

• Make sure that cells in TableSelection are in DOM order.

  

  mlewand

  authored and

  f1ames

  committed
  7094ce2

  Copy full SHA for 7094ce2

• Docs: corrected API docs.

  

  mlewand

  authored and

  f1ames

  committed
  5289cbf

  Copy full SHA for 5289cbf

• Extracted a function for erasing selected cells content.

  

  mlewand

  authored and

  f1ames

  committed
  58fe2e7

  Copy full SHA for 58fe2e7

• Added unit tests for values returned by tabletools insertRow and insertColumn functions.

  

  mlewand

  authored and

  f1ames

  committed
  77dd8af

  Copy full SHA for 77dd8af

• Fixed a bug where merged table would have an invalid structure.

  

  mlewand

  authored and

  f1ames

  committed
  517d900

  Copy full SHA for 517d900

• Added handling for an edge case where, in certain scenario, if rowspan was present table would not be pasted and merged correctly.

  

  mlewand

  authored and

  f1ames

  committed
  76de5a7

  Copy full SHA for 76de5a7

• Refactoring: added code comment and a missing semicolon.

  

  mlewand

  authored and

  f1ames

  committed
  51757d5

  Copy full SHA for 51757d5

• Fixed test fixture id.

  

  mlewand

  authored and

  f1ames

  committed
  1048d62

  Copy full SHA for 1048d62

• Replace custom TableSelection._nodeListToArray with native NodeList.toArray.

  

  Comandeer

  authored and

  f1ames

  committed
  fa6bf28

  Copy full SHA for fa6bf28

• Update unit test.

  

  Comandeer

  authored and

  f1ames

  committed
  770bf8f

  Copy full SHA for 770bf8f

• Add missing ticket number.

  

  Comandeer

  authored and

  f1ames

  committed
  f11e3af

  Copy full SHA for f11e3af

• Refactoring: renamed variable, joined var statements.

  

  mlewand

  authored and

  f1ames

  committed
  6a54e33

  Copy full SHA for 6a54e33

• Changelog entry.

  

  mlewand

  authored and

  f1ames

  committed
  95ea14e

  Copy full SHA for 95ea14e