Disallow creating anchors with space characters

CHANGES.md

@@ -10,6 +10,7 @@ Fixed Issues:
 * [#2996](/~https://github.com/ckeditor/ckeditor4/issues/2996): Fixed: Table header "scope" attribute is incorrect for the "Headers: both" option in the [Table](https://ckeditor.com/cke4/addon/table) dialog.
 * [#4802](/~https://github.com/ckeditor/ckeditor4/issues/4802): Fixed: [Tableselection](https://ckeditor.com/cke4/addon/tableselection) caret moves to the previous cell after tabbing into the next cell and then removing its content.
 * [#5365](/~https://github.com/ckeditor/ckeditor4/issues/5365): Fixed: The value of the [`config.baseFloatZIndex`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_config.html#cfg-baseFloatZIndex) config variable is incorrectly applied to parent dialog when the child dialog is closed resulting in the dialog overlay covering up the dialog. Thanks to [JenoDK](/~https://github.com/JenoDK)!
+* [#5305](/~https://github.com/ckeditor/ckeditor4/issues/5305): Fixed: Anchor name can invalidly include spaces.
 
 ## CKEditor 4.20
 

plugins/link/dialogs/anchor.js

@@ -136,10 +136,23 @@ CKEDITOR.dialog.add( 'anchor', function( editor ) {
 				label: editor.lang.link.anchor.name,
 				required: true,
 				validate: function() {
-					if ( !this.getValue() ) {
+					// https://html.spec.whatwg.org/multipage/dom.html#global-attributes
+					// The id attribute value must not contain any space characters (#5305).
+					// [ space, tabulation, line feed, new line, form feed, carriage return ]
+					var disallowedWhitespacesRegex = /[\u0020\u0009\u000a\u000c\u000d]/g,
+						content = this.getValue();
+
+					if ( !content ) {
 						alert( editor.lang.link.anchor.errorName ); // jshint ignore:line
 						return false;
 					}
+
+					// Disallow creating anchors with space characters (#5305).
+					if ( disallowedWhitespacesRegex.test( content ) ) {
+						alert( editor.lang.link.anchor.errorWhitespace ); // jshint ignore:line
+						return false;
+					}
+
 					return true;
 				}
 			} ]

plugins/link/lang/af.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'af', {
 		title: 'Anker-eienskappe',
 		name: 'Ankernaam',
 		errorName: 'Voltooi die ankernaam asseblief',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'Op element Id',

plugins/link/lang/ar.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'ar', {
 		title: 'خصائص الإشارة المرجعية',
 		name: 'اسم الإشارة المرجعية',
 		errorName: 'الرجاء كتابة اسم الإشارة المرجعية',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'إزالة الإشارة المرجعية'
 	},
 	anchorId: 'حسب رقم العنصر',

plugins/link/lang/az.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'az', {
 		title: 'Xeşin seçimləri',
 		name: 'Xeşin adı',
 		errorName: 'Xeşin adı yanlışdır',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Xeşin adı sil'
 	},
 	anchorId: 'ID görə',

plugins/link/lang/bg.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'bg', {
 		title: 'Настройки на котва',
 		name: 'Име на котва',
 		errorName: 'Моля въведете име на котвата',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Премахване на котва'
 	},
 	anchorId: 'По ID на елемент',

plugins/link/lang/bn.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'bn', {
 		title: 'নোঙর প্রোপার্টি',
 		name: 'নোঙরের নাম',
 		errorName: 'নোঙরের নাম টাইপ করুন',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'নোঙরের আইডি দিয়ে',

plugins/link/lang/bs.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'bs', {
 		title: 'Anchor Properties',
 		name: 'Anchor Name',
 		errorName: 'Please type the anchor name',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'Po Id-u elementa',

plugins/link/lang/ca.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'ca', {
 		title: 'Propietats de l\'àncora',
 		name: 'Nom de l\'àncora',
 		errorName: 'Si us plau, escriviu el nom de l\'ancora',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'Per Id d\'element',

plugins/link/lang/cs.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'cs', {
 		title: 'Vlastnosti záložky',
 		name: 'Název záložky',
 		errorName: 'Zadejte prosím název záložky',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Odstranit záložku'
 	},
 	anchorId: 'Podle Id objektu',

plugins/link/lang/cy.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'cy', {
 		title: 'Priodweddau\'r Angor',
 		name: 'Enw\'r Angor',
 		errorName: 'Teipiwch enw\'r angor',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Tynnwch yr Angor'
 	},
 	anchorId: 'Gan Id yr Elfen',

plugins/link/lang/da.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'da', {
 		title: 'Egenskaber for bogmærke',
 		name: 'Bogmærkenavn',
 		errorName: 'Indtast bogmærkenavn',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Fjern bogmærke'
 	},
 	anchorId: 'Efter element-Id',

plugins/link/lang/de-ch.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'de-ch', {
 		title: 'Ankereigenschaften',
 		name: 'Ankername',
 		errorName: 'Bitte geben Sie den Namen des Ankers ein',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Anker entfernen'
 	},
 	anchorId: 'Nach Elementkennung',

plugins/link/lang/de.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'de', {
 		title: 'Ankereigenschaften',
 		name: 'Ankername',
 		errorName: 'Bitte geben Sie den Namen des Ankers ein',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Anker entfernen'
 	},
 	anchorId: 'Nach Elementkennung',

plugins/link/lang/el.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'el', {
 		title: 'Ιδιότητες άγκυρας',
 		name: 'Όνομα άγκυρας',
 		errorName: 'Παρακαλούμε εισάγετε όνομα άγκυρας',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Αφαίρεση Άγκυρας'
 	},
 	anchorId: 'Βάσει του Element Id',

plugins/link/lang/en-au.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'en-au', {
 		title: 'Anchor Properties',
 		name: 'Anchor Name',
 		errorName: 'Please type the anchor name',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'By Element Id',

plugins/link/lang/en-ca.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'en-ca', {
 		title: 'Anchor Properties',
 		name: 'Anchor Name',
 		errorName: 'Please type the anchor name',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'By Element Id',

plugins/link/lang/en-gb.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'en-gb', {
 		title: 'Anchor Properties',
 		name: 'Anchor Name',
 		errorName: 'Please type the anchor name',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'By Element Id',

plugins/link/lang/en.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'en', {
 		title: 'Anchor Properties',
 		name: 'Anchor Name',
 		errorName: 'Please type the anchor name',
+		errorWhitespace: 'Anchor name cannot contain space characters',
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'By Element Id',

plugins/link/lang/eo.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'eo', {
 		title: 'Ankraj Atributoj',
 		name: 'Ankra Nomo',
 		errorName: 'Bv entajpi la ankran nomon',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Forigi Ankron'
 	},
 	anchorId: 'Per Elementidentigilo',

plugins/link/lang/es-mx.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'es-mx', {
 		title: 'Propiedades del ancla',
 		name: 'Nombre del ancla',
 		errorName: 'Escriba el nombre del ancla',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remover ancla'
 	},
 	anchorId: 'Por Id del elemento',

plugins/link/lang/es.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'es', {
 		title: 'Propiedades de Referencia',
 		name: 'Nombre de la Referencia',
 		errorName: 'Por favor, complete el nombre de la Referencia',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Quitar Referencia'
 	},
 	anchorId: 'Por ID de elemento',

plugins/link/lang/et.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'et', {
 		title: 'Ankru omadused',
 		name: 'Ankru nimi',
 		errorName: 'Palun sisesta ankru nimi',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Eemalda ankur'
 	},
 	anchorId: 'Elemendi id järgi',

plugins/link/lang/eu.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'eu', {
 		title: 'Ainguraren propietateak',
 		name: 'Ainguraren izena',
 		errorName: 'Idatzi ainguraren izena',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Kendu aingura'
 	},
 	anchorId: 'Elementuaren Id-aren arabera',

plugins/link/lang/fa.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'fa', {
 		title: 'ویژگی​های لینک',
 		name: 'نام لینک',
 		errorName: 'لطفا نام لنگر را بنویسید',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'حذف لینک'
 	},
 	anchorId: 'با شناسهٴ المان',

plugins/link/lang/fi.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'fi', {
 		title: 'Ankkurin ominaisuudet',
 		name: 'Nimi',
 		errorName: 'Ankkurille on kirjoitettava nimi',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Poista ankkuri'
 	},
 	anchorId: 'Ankkurin ID:n mukaan',

plugins/link/lang/fo.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'fo', {
 		title: 'Eginleikar fyri marknastein',
 		name: 'Heiti marknasteinsins',
 		errorName: 'Vinarliga rita marknasteinsins heiti',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Strika marknastein'
 	},
 	anchorId: 'Eftir element Id',

plugins/link/lang/fr-ca.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'fr-ca', {
 		title: 'Propriétés de l\'ancre',
 		name: 'Nom de l\'ancre',
 		errorName: 'Veuillez saisir le nom de l\'ancre',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Supprimer l\'ancre'
 	},
 	anchorId: 'Par ID',

plugins/link/lang/fr.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'fr', {
 		title: 'Propriétés de l\'ancre',
 		name: 'Nom de l\'ancre',
 		errorName: 'Veuillez entrer le nom de l\'ancre.',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Supprimer l\'ancre'
 	},
 	anchorId: 'Par ID d\'élément',

plugins/link/lang/gl.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'gl', {
 		title: 'Propiedades da ancoraxe',
 		name: 'Nome da ancoraxe',
 		errorName: 'Escriba o nome da ancoraxe',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Retirar a ancoraxe'
 	},
 	anchorId: 'Polo ID do elemento',

plugins/link/lang/gu.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'gu', {
 		title: 'ઍંકરના ગુણ',
 		name: 'ઍંકરનું નામ',
 		errorName: 'ઍંકરનું નામ ટાઈપ કરો',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'સ્થિર નકરવું'
 	},
 	anchorId: 'ઍંકર એલિમન્ટ Id થી પસંદ કરો',

plugins/link/lang/he.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'he', {
 		title: 'מאפייני נקודת עיגון',
 		name: 'שם לנקודת עיגון',
 		errorName: 'יש להקליד שם לנקודת עיגון',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'מחיקת נקודת עיגון'
 	},
 	anchorId: 'עפ"י זיהוי (ID) האלמנט',

plugins/link/lang/hi.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'hi', {
 		title: 'ऐंकर प्रॉपर्टीज़',
 		name: 'ऐंकर का नाम',
 		errorName: 'ऐंकर का नाम टाइप करें',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'ऍलीमॅन्ट Id से',

plugins/link/lang/hr.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'hr', {
 		title: 'Svojstva sidra',
 		name: 'Ime sidra',
 		errorName: 'Molimo unesite ime sidra',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Ukloni sidro'
 	},
 	anchorId: 'Po Id elementa',

plugins/link/lang/hu.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'hu', {
 		title: 'Horgony tulajdonságai',
 		name: 'Horgony neve',
 		errorName: 'Kérem adja meg a horgony nevét',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Horgony eltávolítása'
 	},
 	anchorId: 'Azonosító szerint',

plugins/link/lang/id.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'id', {
 		title: 'Anchor Properties', // MISSING
 		name: 'Anchor Name', // MISSING
 		errorName: 'Please type the anchor name', // MISSING
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor' // MISSING
 	},
 	anchorId: 'By Element Id', // MISSING

plugins/link/lang/is.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'is', {
 		title: 'Eigindi kaflamerkis',
 		name: 'Nafn bókamerkis',
 		errorName: 'Sláðu inn nafn bókamerkis!',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'Eftir auðkenni einingar',

plugins/link/lang/it.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'it', {
 		title: 'Proprietà ancora',
 		name: 'Nome ancora',
 		errorName: 'Inserici il nome dell\'ancora',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Rimuovi l\'ancora'
 	},
 	anchorId: 'Per id elemento',

plugins/link/lang/ja.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'ja', {
 		title: 'アンカーのプロパティ',
 		name: 'アンカー名',
 		errorName: 'アンカー名を入力してください。',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'アンカーを削除'
 	},
 	anchorId: 'エレメントID',

plugins/link/lang/ka.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'ka', {
 		title: 'ღუზის პარამეტრები',
 		name: 'ღუზუს სახელი',
 		errorName: 'აკრიფეთ ღუზის სახელი',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'ელემენტის Id-თ',

plugins/link/lang/km.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'km', {
 		title: 'លក្ខណៈ​យុថ្កា',
 		name: 'ឈ្មោះ​យុថ្កា',
 		errorName: 'សូម​បញ្ចូល​ឈ្មោះ​យុថ្កា',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'ដក​យុថ្កា​ចេញ'
 	},
 	anchorId: 'តាម ID ធាតុ',

plugins/link/lang/ko.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'ko', {
 		title: '책갈피 속성',
 		name: '책갈피 이름',
 		errorName: '책갈피 이름을 입력하십시오',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: '책갈피 제거'
 	},
 	anchorId: '책갈피 ID',

plugins/link/lang/ku.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'ku', {
 		title: 'خاسیەتی لەنگەر',
 		name: 'ناوی لەنگەر',
 		errorName: 'تکایه ناوی لەنگەر بنووسه',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'لابردنی لەنگەر'
 	},
 	anchorId: 'بەپێی ناسنامەی توخم',

plugins/link/lang/lt.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'lt', {
 		title: 'Žymės savybės',
 		name: 'Žymės vardas',
 		errorName: 'Prašome įvesti žymės vardą',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Pašalinti žymę'
 	},
 	anchorId: 'Pagal žymės Id',

plugins/link/lang/lv.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'lv', {
 		title: 'Iezīmes uzstādījumi',
 		name: 'Iezīmes nosaukums',
 		errorName: 'Lūdzu norādiet iezīmes nosaukumu',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Noņemt iezīmi'
 	},
 	anchorId: 'Pēc elementa ID',

plugins/link/lang/mk.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'mk', {
 		title: 'Anchor Properties',
 		name: 'Anchor Name',
 		errorName: 'Please type the anchor name',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Remove Anchor'
 	},
 	anchorId: 'By Element Id', // MISSING

plugins/link/lang/mn.js

@@ -13,6 +13,7 @@ CKEDITOR.plugins.setLang( 'link', 'mn', {
 		title: 'Зангуугийн шинж чанар',
 		name: 'Зангуугийн нэр',
 		errorName: 'Зангуугийн нэрийг оруулна уу',
+		errorWhitespace: 'Anchor name cannot contain space characters', // MISSING
 		remove: 'Зангууг устгах'
 	},
 	anchorId: 'Элемэнтйн Id нэрээр',