Fix incorrect value of [aria-expanded] on menubuttons
#5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on the newest master. |
sculpt0r
suggested changes
Jul 8, 2022
There was a problem hiding this comment.
@Comandeer I left one significant inline comment. There are two ways to choose there (or you can see even more?). I believe you can choose the right one based on your a11y knowledge. However, if I'm incorrect at some point - please let me know :p So we can establish the approach together 👍
|
I've completely rewritten the solution. I've moved the logic responsible for setting the |
jacekbogdanski
requested review from
jacekbogdanski
and removed request for
sculpt0r
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
As explained in #5144 (comment) I had to find another way to detect if the menu is open. Fortunately, this information is available as an internal property of the button,
button._.on.I was thinking about exposing this property as a public one but finally decided not to do that. This decision really simplified the solution but at the same time – made it a little bit dirty (as the internal property is now used directly inside the
buttonplugin)Which issues does your PR resolve?
Closes #5144.