Review fixes. Adding ignore condition to tests. Little test improveme…

…nts.
ckeditor · Nov 8, 2017 · 67ac4b8 · 67ac4b8
1 parent c0a6c4e
commit 67ac4b8
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 8 deletions.
diff --git a/tests/plugins/widget/integration/table/manual/widgetintable.md b/tests/plugins/widget/integration/table/manual/widgetintable.md
@@ -1,4 +1,4 @@
-@bender-tags: 1027, 4.8.0, widget
+@bender-tags: 1027, 4.8.0, widget, bug
 @bender-ui: collapsed
 @bender-include: ../_helpers/testwidgets.js
 @bender-ckeditor-plugins: undo,clipboard,basicstyles,toolbar,wysiwygarea,widget,table,resize

diff --git a/tests/plugins/widget/integration/table/manual/widgetintablewithtableselection.html b/tests/plugins/widget/integration/table/manual/widgetintablewithtableselection.html
@@ -67,6 +67,13 @@
 <script>
 	CKEDITOR.replace( 'classic', {
 		extraPlugins: 'inlineWidget,blockWidget',
+		on: {
+			pluginsLoaded: function() {
+				if ( !CKEDITOR.plugins.tableselection.isSupportedEnvironment ) {
+					bender.ignore();
+				}
+			}
+		}
 	} );
 
 	CKEDITOR.replace( 'divarea', {

diff --git a/tests/plugins/widget/integration/table/manual/widgetintablewithtableselection.md b/tests/plugins/widget/integration/table/manual/widgetintablewithtableselection.md
@@ -1,7 +1,7 @@
-@bender-tags: 1027, 4.8.0, widget
+@bender-tags: 1027, 4.8.0, widget, bug
 @bender-ui: collapsed
 @bender-include: ../_helpers/testwidgets.js
-@bender-ckeditor-plugins: undo,clipboard,basicstyles,toolbar,wysiwygarea,widget,table,resize
+@bender-ckeditor-plugins: undo,clipboard,basicstyles,toolbar,wysiwygarea,widget,table,resize,tableselection
 
 ----
 

diff --git a/tests/tickets/1027/1.html b/tests/tickets/1027/1.html
@@ -1,5 +1,5 @@
+<label>Lena's path: <input style="border:2px solid black" type="text" value="../../_assets/lena.jpg" readonly></label>
 <textarea id="editor">
-	<p>Lena's path: "../../_assets/lena.jpg"</p>
 	<table border="1" cellpadding="1" cellspacing="1" style="width:500px">
 		<tbody>
 			<tr>
@@ -22,6 +22,13 @@
 </textarea>
 <script>
 	CKEDITOR.replace( 'editor', {
-		extraPlugins: 'image2'
+		extraPlugins: 'image2',
+		on: {
+			pluginsLoaded: function() {
+				if ( !CKEDITOR.plugins.tableselection.isSupportedEnvironment ) {
+					bender.ignore();
+				}
+			}
+		}
 	} );
 </script>
diff --git a/tests/tickets/1027/1.md b/tests/tickets/1027/1.md
@@ -1,11 +1,11 @@
-@bender-tags: 1027, 4.8.0, widget
+@bender-tags: 1027, 4.8.0, widget, bug
 @bender-ui: collapsed
 @bender-ckeditor-plugins: undo,clipboard,basicstyles,toolbar,wysiwygarea,widget,table,tableselection,resize,image2
 
 1. Click on the image of Lena.
-1. Click into another cell and start to (Do not click outside of the table!):
+1. Click into another cell and start to: _(Do not click outside of the table!)_
   * type something
-  * add new image
+  * add new image (path to lena's image is above editor)
 
 **Expected:**
   * You can freely type and edit text.