Skip to content

Commit

Permalink
Merge pull request #753 from ckeditor/t/742
Browse files Browse the repository at this point in the history
Ignore unit test on IE11 which displays a prompt in it.
  • Loading branch information
f1ames authored Aug 10, 2017
2 parents d110386 + 07bcf6b commit 63983c8
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions tests/core/htmldataprocessor.js
Original file line number Diff line number Diff line change
Expand Up @@ -1326,11 +1326,13 @@
// Only WebKit removes preceding spaces in the attribute.
'<p><iframe src="' + ( CKEDITOR.env.webkit ? '' : ' ' ) + 'javascript:window.parent.%xss%;"></iframe></p>' ); // jshint ignore:line

// The `src="&#10;&#106;javascript:..."` is treated as some different protocol in Edge/IE8 and also Chrome on Linux.
// The `src="&#10;&#106;javascript:..."` is treated as some different protocol in few browsers.
// IE8 treats it as an URL and opens it which reloads the whole page.
// While on Edge the tests passes, the browser prompts with "open as" dialog.
// While on Edge and IE11 (starting from Windows 8) the test passes, the browser prompts with "open as" dialog (which may break subsequent tests).
// On Chrome Linux it prompts `Open xdg-open?` dialog, which gains focus so other tests requiring focus fails.
if ( !( CKEDITOR.env.ie && CKEDITOR.env.version == 8 || CKEDITOR.env.edge ) && !( CKEDITOR.env.chrome && bender.tools.env.linux ) ) {
if ( !( CKEDITOR.env.ie && ( CKEDITOR.env.version == 8 || CKEDITOR.env.version == 11 ) ) &&
!( CKEDITOR.env.edge ) &&
!( CKEDITOR.env.chrome && bender.tools.env.linux ) ) {
addXssTC( tcs, 'iframe with src=javascript 4',
'<p><iframe src="&#10;&#106;javascript:window.parent.%xss%;"></iframe></p>',
// In IE9 the new line entity (&#10;) is removed.
Expand Down

0 comments on commit 63983c8

Please sign in to comment.