This repository has been archived by the owner on Sep 11, 2019. It is now read-only.
Add SDK with emoji plugin #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
suggested changes
May 30, 2018
samples/emoji.html
Outdated
|
|
||
| <section class="sdk-contents"> | ||
| <h1>Emoji plugin</h1> | ||
| <p>Emoji plugin provides possibility to easily insert utf symbols, commonly known as emoji, inside editor content. |
There was a problem hiding this comment.
UTF acronym should be uppercased.
samples/emoji.html
Outdated
| <p>Emoji plugin provides possibility to easily insert utf symbols, commonly known as emoji, inside editor content. | ||
| Every emoji has it's own name which is used to select proper symbol from available set. By default pressing <code>:</code> activates drop down suggestion box | ||
| where user can select proper emoji. User can type emoji name after <code>:</code> character to narrow down suggestions on the list.</p> | ||
| <p>Plugin provides configuration options.</p> |
There was a problem hiding this comment.
SDK sample is not a proper place to enumerate config properties. This should be done in dev docs.
|
I'll correct these minor issues, and move the discussion to rest of CKE team. |
|
We will be creating one sample for mentions and emojis, please move the content to the documentation. Emojis should have separate documentation added in the End-user Features -> Working with Document category. |
|
Closing this issue in favor of #249 as the two samples are being merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sample with Emoji
Close #250
To test this PR, it's required to switch branch in
vendor/ckeditor-presets/ckeditortot/1746.