Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize: add plantuml diagram #152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

c5ms
Copy link
Contributor

@c5ms c5ms commented Nov 24, 2024

Why

The existing diagram is created many years ago, and is lack of the package (boundary context) and properties.
So I added the UML diagram with plantuml.

pros:

  1. It's easy to maintain.
  2. It's more clearly to show the relationship.
  3. It's more clearly to show technic concept.

What

  • [add] plantuml for domain diagram

@c5ms c5ms changed the title add plantuml diagram Optimize: add plantuml diagram Nov 24, 2024
@orende
Copy link
Contributor

orende commented Nov 25, 2024

I think this UML diagram is a good addition, but I don't want it to replace the ER diagram, since the two types of diagram serve different purposes (software architecture for UML and database structure for ER). Can you put this image below the Trello board link in the readme and revert the removal of the ER diagram?

@c5ms
Copy link
Contributor Author

c5ms commented Nov 25, 2024

Sounds good for me, I did it.

@mackapappa
Copy link
Contributor

What is the purpose of the diagram? Class diagram, context map or something in between?

@c5ms
Copy link
Contributor Author

c5ms commented Dec 7, 2024

The diagram is a class diagram to show the architecture on domain implementation.

  1. The Boundary context of the subdomains
  2. The relationship between the aggregate roots and value objects

@mackapappa
Copy link
Contributor

I’m not sure I follow you on the bounded contexts.Do you mean that cargo, voyage, handling and location are four different bounded contexts? To me it looks more like a class diagram of classes in the domain layer.

@c5ms
Copy link
Contributor Author

c5ms commented Dec 16, 2024

I was meaning that that the cargo, voyage, handling and location are in the same bounded contexts.
But in this context, they are four different sub-domain and has it's own little context for each aggregate root and it's value objets.And each subdomain has it's design and relationship and interaction with others.
Sorry for confusing you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants