fix issue if adding more disks than scsictrlunitnumber value

[jarvin521]

add_disks fails if adding more disks than the value of controller.scsiCtlrUnitNumber

Description

In my situation I was trying to add 7 disks to my template during kitchen create. My template already has 2 disks to begin with. When creating my VMs I found that controller.scsi.CtlrUnitNumber = 7. When adding my disks and iterating through :Add_disks, line 412 would change next_id from 7 to 8. However, when trying to add another disk after 7 next_id would be 8 again causing the create to fail.

This code change moves highest_id and next_id outside of the loop and no longer relies on the idx variable to determine next_id.

Related Issue

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[jarvin521]

Signed-off-by: Jason Arvin jarvin521@hotmail.com

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud