Support criu-image-streamer through RPC #2536
Open
+35
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Programs calling CRIU through RPC may want access to image streaming for faster data transfer. To use image streaming through RPC, (1) criu-image-streamer must be started by the calling program. (2) The RPC call must enable stream in `criu_opts`. Signed-off-by: Liana Koleva <43767763+lianakoleva@users.noreply.github.com>
|
A friendly reminder that this PR had no activity for 30 days. |
rst0git
reviewed
Jan 19, 2025
| case CR_CPUINFO: | ||
| if (!strcmp(argv[optind + 1], "dump")) | ||
| return O_DUMP; | ||
| /* fallthrough */ |
There was a problem hiding this comment.
Would it be possible to describe these changes in your commit message?
rst0git
reviewed
Jan 19, 2025
| @@ -1261,7 +1257,7 @@ static int handle_cpuinfo(int sk, CriuReq *msg) | |||
| if (pid == 0) { | |||
| int ret = 1; | |||
|
|
|||
| opts.mode = CR_CPUINFO; | |||
| opts.mode = (msg->type == CRIU_REQ_TYPE__CPUINFO_DUMP) ? CR_CPUINFO_DUMP : CR_CPUINFO_CHECK; | |||
There was a problem hiding this comment.
Why do we change opts.mode here?
rst0git
reviewed
Jan 19, 2025
| else if (!strcmp(mode, "cpuinfo") && !strcmp(subcommand, "dump")) | ||
| opts.mode = CR_CPUINFO_DUMP; | ||
| else if (!strcmp(mode, "cpuinfo") && !strcmp(subcommand, "check")) | ||
| opts.mode = CR_CPUINFO_CHECK; |
There was a problem hiding this comment.
It might be better to separate the changes for cpuinfo and opts.stream in different commits:
/~https://github.com/checkpoint-restore/criu/blob/criu-dev/CONTRIBUTING.md#separate-your-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programs calling CRIU through RPC may want access to image streaming for faster data transfer.
To use image streaming through RPC,
(1) criu-image-streamer must be started by the calling program.
(2) The RPC call must enable stream in
criu_opts.The
image_dir_modefunction was modified to be used by RPC as well. This required some changes to accommodate forCR_CPUINFO, which has a subcommanddumporcheck.