ci: do not use 'tail' for skip-file-rwx-check test #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## criu-dev #2307 +/- ##
============================================
- Coverage 70.62% 70.61% -0.01%
============================================
Files 134 134
Lines 33316 33316
============================================
- Hits 23528 23526 -2
- Misses 9788 9790 +2 ☔ View full report in Codecov by Sentry. |
rst0git
reviewed
Nov 30, 2023
adrianreber
force-pushed
the
2023-11-30-skip-rwx-test
branch
from
78253be to
dabb6a0
Compare
avagin
reviewed
Nov 30, 2023
avagin
reviewed
Nov 30, 2023
adrianreber
force-pushed
the
2023-11-30-skip-rwx-test
branch
2 times, most recently
from
712a06a to
2f7daf4
Compare
rst0git
reviewed
Dec 1, 2023
adrianreber
force-pushed
the
2023-11-30-skip-rwx-test
branch
from
2f7daf4 to
f5cd01a
Compare
avagin
reviewed
Dec 1, 2023
Signed-off-by: Adrian Reber <areber@redhat.com>
adrianreber
force-pushed
the
2023-11-30-skip-rwx-test
branch
from
f5cd01a to
7e4ce49
Compare
|
Failing alpine test is tracked here: #2313 |
adrianreber
merged commit e7aca13
into
checkpoint-restore:criu-dev
36 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of 'tail' rely on inotify and after a restore 'tail' is unhappy with the state of inotify and just stops.
This replaces 'tail' with a minimal test in C which just keeps a file open to still be able to test how CRIU reacts if the file mode has changed.
The skip-file-rwx-check test sometimes fails if
killis slower thantailending itself.