Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Collect k8s events #465

Merged
merged 2 commits into from
Jan 24, 2020
Merged

feat: Collect k8s events #465

merged 2 commits into from
Jan 24, 2020

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Jan 15, 2020

Signed-off-by: Anatoliy Bazko abazko@redhat.com

What does this PR do?

Collect k8s events as well as che logs.

The project structure:

.
├── events.txt
├── mkdir-workspacet93uo90gd1acw8zj
│   └── mkdir-workspacet93uo90gd1acw8zj.log
├── workspacet93uo90gd1acw8zj.che-jwtproxy-6454d8877b-5xp26
│   └── verifier.log
└── workspacet93uo90gd1acw8zj.go-cli-bf5459458-fgrdx
    ├── che-machine-execrbr.log
    ├── go-cli.log
    ├── theia-ide3j0.log
    └── vscode-goqsw.log

3 directories, 7 files

What issues does this PR fix or reference?

eclipse-che/che#15604

@sleshchenko
Copy link
Contributor

@tolusha Seems this PR has conflicts against master branch.
Also, it could be useful if you add examples of folder structure we got as a result, along with file content examples (hint probably some info may be copied/pasted from the referenced issue description but I'm not sure if it's aligned to the implementation you provided).

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha
Copy link
Collaborator Author

tolusha commented Jan 22, 2020

@sleshchenko It is ready to review

Copy link
Contributor

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good valuable functionality.
There still a lot of places to be improved to provide better UX like:

  • ask cheNamespace/workspaceName instead of workspaceId, like sleshchenko/java-mysql
  • do not ask namespace since this information is available on Che Sever
    But it would require in MultiUser Che asking CheAccessToken, which is not easy to retrieve. And as we discussed offline, chectl login could help with it, but it's not really easy to do. We need to investigate it more and introduce something like context similar to that kubectl has.

So, I believe this is a great start point which can be improved later 👍
Please, consider registering the issues we discussed.

@tolusha tolusha added the enhancement New feature or request label Jan 24, 2020
@tolusha tolusha merged commit d12f18b into master Jan 24, 2020
@tolusha tolusha deleted the ab/events branch January 24, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants