-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Collect k8s events #465
Conversation
@tolusha Seems this PR has conflicts against master branch. |
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@sleshchenko It is ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good valuable functionality.
There still a lot of places to be improved to provide better UX like:
- ask cheNamespace/workspaceName instead of workspaceId, like sleshchenko/java-mysql
- do not ask namespace since this information is available on Che Sever
But it would require in MultiUser Che asking CheAccessToken, which is not easy to retrieve. And as we discussed offline, chectl login could help with it, but it's not really easy to do. We need to investigate it more and introduce something like context similar to that kubectl has.
So, I believe this is a great start point which can be improved later 👍
Please, consider registering the issues we discussed.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do?
Collect k8s events as well as che logs.
The project structure:
What issues does this PR fix or reference?
eclipse-che/che#15604