-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable box annotation label as label sub-element #725
Conversation
@kurkle the following options are missing in the label of box annotation because the goal was to use the box rendering options.
In my opinion this deserves a specific PR, with doc and new test cases. About callout, I don't see any use case. The callout is thought to outline a point linking it to a label. I would like do not enable it in box annotation. What do you think? |
Conflicts: types/element.d.ts
I don't see a use case for the callout either, but you never know what people come up with. |
I agree for this reason I haven't started yet. All those options could be defined as commons. |
Yes, a fast path. breaking change anyway! |
done |
@kurkle thanks for approval. What about CC issues? |
This PR moves label node of box annotation to sub element.
This PR enables the box label animation.