Remove all clang tidy warnings from the core library of Lethe #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
added
WIP
blaisb
force-pushed
the
core_fix_warnings
branch
2 times, most recently
from
1f8eb28 to
881f23b
Compare
blaisb
changed the title
blaisb
changed the title
blaisb
requested review from
AmishgaAlphonius
and removed request for
AmishgaAlphonius
blaisb
added
Ready for review
and removed
WIP
hepap
reviewed
Aug 20, 2024
| @@ -291,7 +291,7 @@ fill_vectors_from_file(std::map<std::string, std::vector<double>> &map, | |||
| line_of_data = Utilities::string_to_double(list_of_words_clean); | |||
| for (unsigned int i = 0; i < line_of_data.size(); ++i) | |||
| { | |||
| map[column_names[i]].push_back(line_of_data[i]); | |||
| map[column_names[i]].emplace_back(line_of_data[i]); | |||
There was a problem hiding this comment.
What is the advantage of using emplace_back here?
There was a problem hiding this comment.
Like we discussed :) prevents the generation of a copy.
blaisb
added a commit
that referenced
this pull request
Aug 27, 2024
Description This is a follow up to #1243 but for the solvers library. Testing All tests should pass.
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
…polymtl#1243) Description Since I have deployed the new CI action, we are able to identify many more alerts using clang sanitizer. This PR aims at removing the alerts from the core library of Lethe. We still have warnings when we compile with clang, but this will need an additional CI instance check. Testing All units tests and application tests should pass before this is merged. Former-commit-id: afe7dbb
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description This is a follow up to chaos-polymtl#1243 but for the solvers library. Testing All tests should pass. Former-commit-id: 65020c6
blaisb
added a commit
that referenced
this pull request
Sep 30, 2024
Description Since I have deployed the new CI action, we are able to identify many more alerts using clang sanitizer. This PR aims at removing the alerts from the core library of Lethe. We still have warnings when we compile with clang, but this will need an additional CI instance check. Testing All units tests and application tests should pass before this is merged. Former-commit-id: afe7dbb
blaisb
added a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since I have deployed the new CI action, we are able to identify many more alerts using clang sanitizer. This PR aims at removing the alerts from the core library of Lethe. We still have warnings when we compile with clang, but this will need an additional CI instance check.
Testing
All units tests and application tests should pass before this is merged.
Code related list:
Pull request related list: