Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if phage name contains 'phage' #304

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Conversation

ninabernick
Copy link
Contributor

Checks if virus name contains "phage" when assigning is_phage. Captures case of unclassified bacterial phage without family.

Copy link
Collaborator

@rzlim08 rzlim08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, are we relatively sure that everything named "phage" is a phage? Like there's no e.g. taxa named "phage-like" or anything?

@rzlim08
Copy link
Collaborator

rzlim08 commented Nov 8, 2023

Nice, are we relatively sure that everything named "phage" is a phage? Like there's no e.g. taxa named "phage-like" or anything?

Actually would we mis-classify the clade "aphagea"?

@ninabernick
Copy link
Contributor Author

Nice, are we relatively sure that everything named "phage" is a phage? Like there's no e.g. taxa named "phage-like" or anything?

Actually would we mis-classify the clade "aphagea"?

Great catch! Looks like the old query was checking for a whole word match to "phage", I'll fix that

@ninabernick ninabernick merged commit c4d7b9c into main Nov 8, 2023
11 checks passed
@ninabernick ninabernick deleted the ninabernick/phage_name branch November 8, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants