Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RealPLKSR LayerNorm #313

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

the-database
Copy link
Contributor

@the-database the-database commented Jan 2, 2025

This PR adds the LayerNorm variant of RealPLKSR, which has the following benefits over the old version which used GroupNorm:

  • Better metrics. One RealPLKSR LayerNorm model was confirmed to have better metrics than the official PLKSR model.
  • Better visual quality.
  • Faster inference, especially when using channels last. Reduced VRAM usage as well.
  • Supports FP16, just like PLKSR does (see the paper for confirmation that all training and tests for PLKSR were done in FP16). I assume supports_half was set to False due to not working with the old RealPLKSR, so I updated supports_half to be True for PLKSR and RealPLKSR LayerNorm, and False for the old RealPLKSR.

@joeyballentine joeyballentine merged commit 3a32e72 into chaiNNer-org:main Jan 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants