Make transaction tracing timeout configurable #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rpc.reqTimeout value is now passed to the blockchain node as the timeout parameter when tracing transactions.
piersy
force-pushed
the
piersy/provide-configurable-transaction-tracing-timeout
branch
from
679782c to
79c553b
Compare
eelanagaraj
approved these changes
Jan 21, 2022
README.md
Outdated
| --rpc.address string Listening address for http server | ||
| --rpc.port uint Listening port for http server (default 8080) | ||
| --rpc.reqTimeout duration Timeout for requests to this service, this also controls the timeout sent to the blockchain node for trace transaction requests (default 25s) | ||
| --txtrace.Timeout duration Timeout to use when when making trace transaction requests to a full node (default 50s) |
There was a problem hiding this comment.
Is this arg used? I thought that rpc.reqTimeout is now used for both? (That said, I think having two separate args if possible may be useful IMO)
There was a problem hiding this comment.
No that is a phantom arg! I started with a separate flag, but given that the rpc.ReqTimeout would override the timeout set for tracing I thought it was simpler just to have one. And then I promptly forgot to update the docs! thanks!
piersy
deleted the
piersy/provide-configurable-transaction-tracing-timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rpc.reqTimeout value is now passed to the blockchain node as the
timeout parameter when tracing transactions.
Fixes #180 in tandem with
celo-org/kliento#21 and celo-org/kliento#20
Also bumps the version of go used by C from v1.14 to v1.17 because
the build was failing to handle missing
io/fspackage.See - golang/go#44557