Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update consensus-node page #1662

Merged
merged 13 commits into from
Aug 5, 2024
Merged

docs: update consensus-node page #1662

merged 13 commits into from
Aug 5, 2024

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Aug 5, 2024

Overview

Resolves #1640

Summary by CodeRabbit

  • New Features

    • Enhanced hardware requirements for consensus nodes to improve performance capabilities.
  • Bug Fixes

    • Simplified language in multiple documents to improve clarity without affecting functionality.
  • Documentation

    • Updated terminology for various node types, changing "full consensus node" to "consensus node" for consistency.
    • Streamlined guidance in documentation related to consensus nodes, including clearer instructions and descriptions across various topics.

Copy link
Contributor

coderabbitai bot commented Aug 5, 2024

Warning

Rate limit exceeded

@jcstein has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 59 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 79e0285 and 2b77b7b.

Walkthrough

The recent updates across multiple documentation files involve a significant shift in terminology, changing "full consensus nodes" to "consensus nodes" for clarity and consistency. These changes also include updates to hardware requirements, reflecting increased demands for running these nodes. Overall, the modifications enhance user understanding and improve the guidance provided for setting up consensus nodes in the Celestia network.

Changes

File Paths Change Summary
.vitepress/config.ts, developers/arbitrum-integration.md, developers/blobstream-proof-queries.md Changed "Full consensus node" to "Consensus node" for clarity.
nodes/* (multiple files) Updated terminology from "full consensus node" to "consensus node"; simplified wording and increased hardware requirements.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Documentation
    User->>Documentation: Request guidance on consensus node setup
    Documentation-->>User: Provide updated terminology and instructions
    User->>Documentation: Check hardware requirements
    Documentation-->>User: Show increased specifications
Loading

Assessment against linked issues

Objective Addressed Explanation
Update title to: Full consensus node (1640)
"hardware minimum requirements" -> "minimum hardware requirements" (1640)
Consistent usage of "full consensus node" vs. "consensus full node" (1640)
Provide more detailed system requirements for bridge nodes (1633) Documentation does not address specific system limits.
Explain what persistent peers do (1640) Unclear if this explanation was added.

Possibly related issues

Poem

🐇 In the meadow where the nodes do play,
The terms have shifted in a clearer way.
No longer "full," just "consensus" shines,
Guiding users through their setup lines.
With updated specs, they hop and cheer,
In the world of Celestia, all is clear! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://celestiaorg.github.io/docs-preview/./pr-1662/
on branch main at 2024-08-05 21:03 UTC

Co-authored-by: Rootul P <rootulp@gmail.com>
@jcstein jcstein self-assigned this Aug 5, 2024
@jcstein jcstein changed the title docs: update full-consensus-node page docs: update consensus-node page Aug 5, 2024
@jcstein
Copy link
Member Author

jcstein commented Aug 5, 2024

Moving update of graphics to #1650 for now

@jcstein jcstein requested a review from rootulp August 5, 2024 19:23
@jcstein jcstein marked this pull request as ready for review August 5, 2024 19:23
@jcstein jcstein added the documentation Improvements or additions to documentation label Aug 5, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (2)
nodes/hardfork-process.md (1)

43-43: Consider simplifying "prior to."

The phrase "prior to" might be wordy. Consider using "before" for conciseness.

-  download and run a celestia-app v2.x.x binary prior to the `--v2-upgrade-height`
+  download and run a celestia-app v2.x.x binary before the `--v2-upgrade-height`
Tools
LanguageTool

[style] ~43-~43: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ad and run a celestia-app v2.x.x binary prior to the --v2-upgrade-height to remain on ...

(EN_WORDINESS_PREMIUM_PRIOR_TO)

nodes/mocha-testnet.md (1)

96-96: Consider simplifying "in order to."

The phrase "in order to" might be wordy. Consider using "to" for conciseness.

-  run a local [consensus node](./consensus-node.md) in order to download full blocks from it.
+  run a local [consensus node](./consensus-node.md) to download full blocks from it.
Tools
LanguageTool

[style] ~96-~96: Consider a shorter alternative to avoid wordiness.
Context: ...l consensus node in order to download full blocks from it. ::: - `p...

(IN_ORDER_TO_PREMIUM)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0091ee7 and d82ae8e.

Files selected for processing (13)
  • .vitepress/config.ts (1 hunks)
  • developers/arbitrum-integration.md (1 hunks)
  • developers/blobstream-proof-queries.md (1 hunks)
  • nodes/arabica-devnet.md (1 hunks)
  • nodes/celestia-app-vesting.md (2 hunks)
  • nodes/consensus-node.md (10 hunks)
  • nodes/full-storage-node.md (1 hunks)
  • nodes/hardfork-process.md (1 hunks)
  • nodes/mainnet.md (2 hunks)
  • nodes/mocha-testnet.md (2 hunks)
  • nodes/overview.md (1 hunks)
  • nodes/systemd.md (1 hunks)
  • nodes/validator-node.md (3 hunks)
Files skipped from review due to trivial changes (9)
  • .vitepress/config.ts
  • developers/arbitrum-integration.md
  • developers/blobstream-proof-queries.md
  • nodes/arabica-devnet.md
  • nodes/celestia-app-vesting.md
  • nodes/full-storage-node.md
  • nodes/mainnet.md
  • nodes/overview.md
  • nodes/systemd.md
Additional context used
LanguageTool
nodes/hardfork-process.md

[style] ~43-~43: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ad and run a celestia-app v2.x.x binary prior to the --v2-upgrade-height to remain on ...

(EN_WORDINESS_PREMIUM_PRIOR_TO)

nodes/mocha-testnet.md

[style] ~96-~96: Consider a shorter alternative to avoid wordiness.
Context: ...l consensus node in order to download full blocks from it. ::: - `p...

(IN_ORDER_TO_PREMIUM)

nodes/consensus-node.md

[uncategorized] ~210-~210: Possible missing comma found.
Context: ...s node will sync using block sync; that is request, validate and execute every blo...

(AI_HYDRA_LEO_MISSING_COMMA)

Additional comments not posted (15)
nodes/validator-node.md (3)

22-24: Update hardware requirements.

The hardware requirements have been updated to reflect increased resource needs. Ensure these changes are communicated to users.


33-33: Terminology update for clarity.

The link text has been updated for clarity. Ensure consistency across the documentation.


244-244: Minor terminology update.

The link text has been updated to improve clarity and consistency.

nodes/mocha-testnet.md (1)

27-27: Terminology update for clarity.

The link text has been updated for clarity. Ensure consistency across the documentation.

nodes/consensus-node.md (11)

2-2: Update the description to reflect the new terminology.

The description has been updated to remove the term "full" and now reads "Learn how to set up a Celestia consensus node."


6-6: Update the title to reflect the new terminology.

The title has been updated from "Setting up a Celestia full consensus node" to "Consensus node."


20-26: Update the hardware requirements to reflect increased specifications.

The minimum hardware requirements have been updated to:

  • Memory: 16 GB RAM
  • CPU: Quad-Core
  • Disk: 2 TB SSD Storage
  • Bandwidth: 1 Gbps for Download/1 Gbps for Upload

These changes reflect the increased resource demands for running a consensus node.


29-29: Update the section title for clarity and consistency.

The section title has been updated from "Setting up a full consensus node" to "Set up a consensus node."


Line range hint 106-140:
Mark the section on setting persistent peers as optional and provide detailed instructions.

The section has been marked as optional and includes detailed instructions on how to set persistent peers in the config.toml file. This is useful for running a local devnet or a sentry node.


Line range hint 144-165:
Mark the section on connecting a consensus node to a bridge node as optional.

The section has been marked as optional and includes detailed instructions on how to enable transaction indexing and retain all block data when connecting to a bridge node.


Line range hint 165-174:
Update the section title and content for clarity.

The section title has been updated from "Querying transactions by hash" to "Query transactions by hash." The content includes instructions on how to enable transaction indexing.


Line range hint 174-186:
Mark the section on accessing historical state as optional.

The section has been marked as optional and includes detailed instructions on how to run an archive node to query historical state.


Line range hint 186-201:
Update the section title and content for clarity.

The section title has been updated from "Saving on storage requirements" to "Save on storage requirements." The content includes instructions on how to configure pruning settings to save on storage.


201-207: Update the section title and content to include a table format for different sync types.

The section title has been updated from "Syncing" to "Sync types." The content includes a table format that clearly delineates different sync types and their characteristics.


Line range hint 249-274:
Update the section title and content to include detailed instructions for quick sync.

The section title has been updated to "Option 3: Quick sync." The content includes detailed instructions on how to quick-sync from a snapshot.

Copy link
Contributor

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d82ae8e and 0cd1df0.

Files selected for processing (2)
  • nodes/consensus-node.md (10 hunks)
  • nodes/overview.md (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • nodes/overview.md
Additional comments not posted (8)
nodes/consensus-node.md (8)

2-2: LGTM!

The updated description aligns with the new terminology.


6-6: LGTM!

The updated title aligns with the new terminology.


20-26: LGTM!

The updated hardware requirements reflect the increased specifications.


29-29: LGTM!

The streamlined setup section improves clarity and efficiency.


Line range hint 106-140: LGTM!

The optional section on persistent peers provides clearer instructions and enhances readability.


Line range hint 144-186: LGTM!

The optional section on storage and pruning configurations provides clearer instructions and enhances readability.


201-216: LGTM!

The reorganized sync types section improves clarity and provides a clearer framework for understanding synchronization methods.


329-329: LGTM!

The extra resources section provides useful optional configurations and additional resources.

Co-authored-by: Rootul P <rootulp@gmail.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
nodes/consensus-node.md (1)

2-2: Clarify the description.

Consider rephrasing the description for better clarity.

- description: Learn how to set up a Celestia consensus node.
+ description: Learn how to set up and configure a Celestia consensus node.
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0cd1df0 and 79e0285.

Files selected for processing (1)
  • nodes/consensus-node.md (10 hunks)
Additional comments not posted (16)
nodes/consensus-node.md (16)

6-6: Title update is appropriate.

The title change from "Setting up a Celestia full consensus node" to "Consensus node" is clear and concise.


14-15: Fix the typo in the introduction.

There is a typo in the word "Cconsensus."

- Cconsensus nodes allow you to sync the entire blockchain history in the Celestia
+ Consensus nodes allow you to sync the entire blockchain history in the Celestia

20-20: Title update is appropriate.

The title change from "Hardware requirements" to "Minimum hardware requirements" is clear and emphasizes baseline specifications.


22-26: Update hardware requirements.

The updated hardware requirements reflect increased specifications, which is appropriate for running a consensus node.


29-29: Title update is appropriate.

The title change from "Setting up a full consensus node" to "Set up a consensus node" is clear and concise.


Line range hint 29-106:
Streamline setup instructions.

The updated setup instructions are clear and concise. The removal of the repository cloning step and the use of the download-genesis command improve the process.


Line range hint 106-140:
Clear instructions for setting persistent peers.

The instructions for setting persistent peers are clear and provide useful information for different networks.


Line range hint 144-165:
Clear instructions for optional configurations.

The instructions for connecting to a bridge node and querying transactions are clear and provide useful information for users.


Line range hint 174-186:
Clear instructions for accessing historical state.

The instructions for accessing historical state are clear and provide useful information for users.


Line range hint 186-201:
Clear instructions for saving storage requirements.

The instructions for saving storage requirements are clear and provide useful information for users.


201-201: Title update is appropriate.

The title change from "Syncing" to "Sync types" is clear and provides a better framework for understanding the synchronization methods.


204-208: Fix the missing comma.

There is a missing comma in the sentence "that is request, validate and execute every block up to the head of the blockchain."

- that is request, validate and execute every block up to the head of the blockchain.
+ that is, request, validate, and execute every block up to the head of the blockchain.

Line range hint 212-245:
Clear instructions for sync types.

The instructions for the different sync types are clear and provide useful information for users.


Line range hint 245-325:
Clear instructions for starting the consensus node and configuring an RPC endpoint.

The instructions for starting the consensus node and configuring an RPC endpoint are clear and provide useful information for users.


Line range hint 325-374:
Clear instructions for transaction indexer configuration and discarding ABCI responses.

The instructions for transaction indexer configuration and discarding ABCI responses are clear and provide useful information for users.


Line range hint 374-400:
Clear and useful FAQ section.

The FAQ section provides useful information for troubleshooting common issues.

@jcstein jcstein merged commit 7db1c97 into main Aug 5, 2024
3 checks passed
@jcstein jcstein deleted the jcs/1640 branch August 5, 2024 21:03
@jcstein
Copy link
Member Author

jcstein commented Aug 5, 2024

you're welcome @rootulp ! thank you for the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ideas for full-consensus-node page
2 participants