Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper default for FormatXTC's delta_k #490

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Proper default for FormatXTC's delta_k #490

merged 3 commits into from
Feb 24, 2022

Conversation

phyy-nx
Copy link
Contributor

@phyy-nx phyy-nx commented Feb 24, 2022

No description provided.

@phyy-nx
Copy link
Contributor Author

phyy-nx commented Feb 24, 2022

This will fix an error in XFEL CI, psana version, that came from #484, so I'll merge this after the checks pass. The error was that delta_k needs to have a default of 0 instead of None.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #490 (ca972f7) into main (8d9a462) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   40.60%   40.60%           
=======================================
  Files         177      177           
  Lines       15564    15564           
  Branches     2779     2779           
=======================================
  Hits         6320     6320           
  Misses       8703     8703           
  Partials      541      541           

@phyy-nx phyy-nx merged commit a6a15f3 into main Feb 24, 2022
@phyy-nx phyy-nx deleted the deltak_default branch February 24, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants