Tidy up dlsnxs2cbf #311
Merged
Tidy up dlsnxs2cbf #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhwilliams
changed the title
Codecov Report
@@ Coverage Diff @@
## main #311 +/- ##
==========================================
- Coverage 64.67% 64.65% -0.02%
==========================================
Files 177 177
Lines 15274 15263 -11
Branches 2068 2066 -2
==========================================
- Hits 9878 9869 -9
+ Misses 4853 4851 -2
Partials 543 543 |
# Conflicts: # util/dlsnxs2cbf.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dxtbx.dlsnxs2cbfseems to have some idiosyncratic code that could do with tidying up. In particular, we ought to be using a context manager for file input as well as output, and the functiondepends_onis either a no-op (quite probable) or it is probing implicitly for some exception that that it does not handle, in which case that behaviour ought to be documented.