Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple import Cpp library in a single unit #4814

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

bricknerb
Copy link
Contributor

Instead of compiling the imported file, generate a C++ header that includes all Cpp import files.
Part of #4666

Instead of compiling the imported file, generate a C++ header that includes all `Cpp` import files.
Part of carbon-language#4666
@bricknerb bricknerb requested a review from jonmeow January 16, 2025 14:45
@github-actions github-actions bot requested a review from chandlerc January 16, 2025 14:45
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

toolchain/check/import_cpp.cpp Outdated Show resolved Hide resolved
toolchain/check/import_cpp.cpp Outdated Show resolved Hide resolved
toolchain/check/import_cpp.cpp Outdated Show resolved Hide resolved
toolchain/check/import_cpp.cpp Outdated Show resolved Hide resolved
@bricknerb bricknerb requested a review from jonmeow January 17, 2025 07:26
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@jonmeow
Copy link
Contributor

jonmeow commented Jan 17, 2025

Minor note, some churn in tests (from #4818). I'll leave this to you to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants