Updated the sources to allow for custom curreny #11
+45
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… command-line flags. New command-line flags: --currency (-c): Allows the user to set an arbitrary currency symbol. --suffixed : Tells reckon to use the currency as a suffix, e.g. 10 SEK, as opposed to a prefix like $10.
| options[:currency] = '$' | ||
| end | ||
|
|
||
| unless options[:suffixed] |
There was a problem hiding this comment.
This is probably not needed since options[:suffixed] will be nil, which evaluates to false in any if statements.
|
This looks like a great contribution, thank you @zebh! I've left a couple of comments. |
|
Thanks for the comments. With the languages I'm used to, I would expect everything to go crazy for trying to treat a nil as a bool. Pays off to actually know the language tricks! :) |
cantino
added a commit
that referenced
this pull request
Jun 26, 2013
Updated the sources to allow for custom curreny
|
Thanks @zebh! |
Closed
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would solve issue #7 and seems to work fine.
If you have any feedback, I would love to hear it. Ruby is and have never been my primary language so maybe this could have been solved differently.
It still defaults to a prefixed $ for currency to avoid breaking backwards-compatibility, but then adds the ability to arbitrarily change the currency to allow for anything to be added. Including time, stocks, cows, you name it! :)