Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/cpu-control: allow to control cpufreq tunables #8127

Merged
merged 2 commits into from
Feb 17, 2020
Merged

interfaces/cpu-control: allow to control cpufreq tunables #8127

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47d5055
interfaces/cpu-control: allow to control cpufreq tunables
alexmurray Feb 10, 2020
7444379
interfaces/cpu-control: Address feedback from PR#8127
alexmurray Feb 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions interfaces/builtin/cpu_control.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,24 @@ const cpuControlConnectedPlugAppArmor = `
/sys/devices/system/cpu/cpu*/online rw,
/sys/devices/system/cpu/smt/* r,
/sys/devices/system/cpu/smt/control w,

# https://www.kernel.org/doc/html/latest/admin-guide/pm/cpufreq.html#policy-interface-in-sysfs
/sys/devices/system/cpu/cpufreq/* r,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be: /sys/devices/system/cpu/cpufreq/{,**} r,

/sys/devices/system/cpu/cpufreq/policy*/* r,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the above suggestion, this rule can go away.

/sys/devices/system/cpu/cpufreq/policy*/energy_performance_preference w,
/sys/devices/system/cpu/cpufreq/policy*/scaling_governor w,
/sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq w,
/sys/devices/system/cpu/cpufreq/policy*/scaling_min_freq w,
/sys/devices/system/cpu/cpufreq/policy*/scaling_setspeed w,
/sys/devices/system/cpu/cpufreq/boost w,

# https://www.kernel.org/doc/html/latest/admin-guide/pm/intel_pstate.html#user-space-interface-in-sysfs
/sys/devices/system/cpu/intel_pstate/* r,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps /sys/devices/system/cpu/intel_pstate/{,*} r, instead?

/sys/devices/system/cpu/intel_pstate/hwp_dynamic_boost w,
/sys/devices/system/cpu/intel_pstate/max_perf_pct w,
/sys/devices/system/cpu/intel_pstate/min_perf_pct w,
/sys/devices/system/cpu/intel_pstate/no_turbo w,
/sys/devices/system/cpu/intel_pstate/status w,
`

func init() {
Expand Down