Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Remove PlainChat from pages router #19588

Merged
merged 1 commit into from
Feb 27, 2025
Merged

perf: Remove PlainChat from pages router #19588

merged 1 commit into from
Feb 27, 2025

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Feb 26, 2025 •
edited
Loading

What does this PR do?

  • Remove PlainChat instance from Pages Router as it's no longer needed (we already have an instance of PlainChat in app router)

Tested

Screenshot 2025-02-26 at 4 14 19 PM Screenshot 2025-02-26 at 4 12 39 PM Screenshot 2025-02-26 at 4 12 51 PM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • DM me and I will send you the env variables (only if you are on Cal.com team :D)

@graphite-app graphite-app bot requested a review from a team February 26, 2025 20:50
@hbjORbj hbjORbj changed the title chore: remove plainchat from pages router chore: Remove PlainChat instance from pages router Feb 26, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 26, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 2:42pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 2:42pm

@hbjORbj hbjORbj changed the title chore: Remove PlainChat instance from pages router chore: Remove PlainChat instance from pages router + pass isPlainChatEnabled prop from /app/layout.tsx Feb 26, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 26, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/26/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj changed the title chore: Remove PlainChat instance from pages router + pass isPlainChatEnabled prop from /app/layout.tsx perf: Remove dynamic import for PlainChat and its instance from pages router Feb 26, 2025
@hbjORbj hbjORbj changed the title perf: Remove dynamic import for PlainChat and its instance from pages router perf: make irregular full page reload go away Feb 26, 2025
@hbjORbj hbjORbj enabled auto-merge (squash) February 26, 2025 21:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

E2E results are ready!

zomars
zomars reviewed Feb 26, 2025
View reviewed changes
@hbjORbj hbjORbj changed the title perf: make irregular full page reload go away perf: Remove PlainChat from pages router Feb 27, 2025
@hbjORbj hbjORbj requested a review from zomars February 27, 2025 14:41
@hbjORbj hbjORbj force-pushed the chore/remove-PlainChat-from-pages-router branch from a3b39c1 to 32c0e36 Compare February 27, 2025 14:42
@hbjORbj
Copy link
Contributor Author

hbjORbj commented Feb 27, 2025 •
edited
Loading

@zomars I reduced the scope of this PR to removing the component from pages router! safe to merge now

@hbjORbj hbjORbj merged commit b6caf86 into main Feb 27, 2025
39 checks passed
@hbjORbj hbjORbj deleted the chore/remove-PlainChat-from-pages-router branch February 27, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomars zomars zomars approved these changes

Assignees
No one assigned
Labels
consumer core area: core, team members only ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @zomars @keithwillcode