Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove wrong conditions to fetch users on /bookings #19580

Merged
merged 3 commits into from
Feb 27, 2025
Merged

fix: remove wrong conditions to fetch users on /bookings #19580

merged 3 commits into from
Feb 27, 2025

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Feb 26, 2025 •
edited
Loading

What does this PR do?

We've been fetching unnecessarily too many bookings on /bookings page due to some conditions. This PR removes:

  • Bookings from event types where selected user is a host of
  • Bookings from event types where selected user is a member of

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Feb 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 4:35pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 4:35pm

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 26, 2025
@eunjae-lee eunjae-lee added ready-for-e2e and removed core area: core, team members only consumer labels Feb 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

E2E results are ready!

@eunjae-lee eunjae-lee marked this pull request as ready for review February 27, 2025 14:06
@graphite-app graphite-app bot requested a review from a team February 27, 2025 14:06
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Feb 27, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 27, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/27/25)

1 reviewer was added to this PR based on Keith Williams's automation.

hbjORbj
hbjORbj previously approved these changes Feb 27, 2025
View reviewed changes
@eunjae-lee eunjae-lee enabled auto-merge (squash) February 27, 2025 15:46
@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 27, 2025
hbjORbj
hbjORbj approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eunjae-lee eunjae-lee merged commit 5be2b5b into main Feb 27, 2025
38 checks passed
@eunjae-lee eunjae-lee deleted the fix/remove-wrong-conditions-from-bookings branch February 27, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eunjae-lee @hbjORbj @keithwillcode