Merge pull request #201 from bobot/deriver_qualified_name

Add regression tests for qualified type
c-cube · Dec 3, 2021 · 7787b6e · 7787b6e
2 parents 3ee3c01 + fac2c39
commit 7787b6e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/src/ppx_deriving_qcheck/ppx_deriving_qcheck.ml b/src/ppx_deriving_qcheck/ppx_deriving_qcheck.ml
@@ -58,7 +58,7 @@ let gen ~loc ?(env = TypeGen.empty) lg =
   match lg with
   | Lident s ->
       Option.value ~default:(name s |> A.evar) @@ TypeGen.find_opt s env
-  | Ldot (lg, s) -> A.(pexp_construct (Located.mk @@ Ldot (lg, name s)) None)
+  | Ldot (lg, s) -> A.(pexp_ident (Located.mk @@ Ldot (lg, name s)))
   | Lapply (_, _) -> raise (Invalid_argument "gen received an Lapply")
 
 let frequency ~loc l = [%expr QCheck.Gen.frequency [%e l]]

diff --git a/test/ppx_deriving_qcheck/deriver/dune b/test/ppx_deriving_qcheck/deriver/dune
@@ -1,4 +1,11 @@
 (test
  (name test)
+ (modules test)
  (libraries alcotest ppxlib ppx_deriving_qcheck qcheck)
  (preprocess (pps ppxlib.metaquot)))
+
+(test
+ (name test_qualified_names)
+ (modules test_qualified_names)
+ (libraries qcheck)
+ (preprocess (pps ppx_deriving_qcheck)))
diff --git a/test/ppx_deriving_qcheck/deriver/test_qualified_names.ml b/test/ppx_deriving_qcheck/deriver/test_qualified_names.ml
@@ -0,0 +1,7 @@
+module Q = struct
+   type t = int
+    [@@deriving qcheck]
+end
+
+type t = Q.t
+ [@@deriving qcheck]