Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for platform API 0.3, drop support for platform API 0.1 #509

Merged
merged 3 commits into from
Feb 25, 2020
Merged

Add support for platform API 0.3, drop support for platform API 0.1 #509

merged 3 commits into from
Feb 25, 2020

Conversation

jromero
Copy link
Member

@jromero jromero commented Feb 20, 2020 •
edited
Loading

Resolved #507

@jromero @ameyer-pivotal
Add support for Platform API 0.3
2eaef33 
Signed-off-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Andrew Meyer <meyeran@vmware.com>
@jromero jromero requested a review from a team as a code owner February 20, 2020 17:38
@jromero
Remove support for Platform API 0.1
7902cb3 
Signed-off-by: Javier Romero <rjavier@vmware.com>
@jromero jromero force-pushed the feature/507-platform-0.3 branch from 487f55e to 7902cb3 Compare February 20, 2020 18:56
@natalieparellano
Copy link
Member

Approving -

Acceptance steps:

Verified it works with platform API 0.3:

$  ./out/pack inspect-builder platform-03
Inspecting builder: platform-03

REMOTE:
(not present)

LOCAL:

Created By:
  Name: Pack CLI
  Version: dev-2020-02-25-10:15:04

Stack:
  ID: io.buildpacks.samples.stacks.alpine

Lifecycle:
  Version: 0.0.0
  Buildpack API: 0.2
  Platform API: 0.3

Run Images:
  cnbs/sample-stack-run:alpine

Buildpacks:
  ID                                          VERSION
  io.buildpacks.samples.java-maven            0.0.1
  io.buildpacks.samples.kotlin-gradle         0.0.1
  io.buildpacks.samples.hello-universe        0.0.1
  io.buildpacks.samples.hello-moon            0.0.1
  io.buildpacks.samples.hello-world           0.0.1

Detection Order:
  Group #1:
    io.buildpacks.samples.java-maven@0.0.1    
  Group #2:
    io.buildpacks.samples.kotlin-gradle@0.0.1    
  Group #3:
    io.buildpacks.samples.hello-universe@0.0.1  

./out/pack build app-03 -B platform-03 -p ~/workspace/samples/apps/java-maven/
...
Successfully built image app-03

Verified it works with platform API 0.2:

$  ./out/pack inspect-builder cnbs/sample-builder:alpine
Inspecting builder: cnbs/sample-builder:alpine    

LOCAL:

Created By:
  Name: Pack CLI
  Version: v0.8.1 (git sha: e776ebf0096363bbac60771a456af941827316be)

Stack:
  ID: io.buildpacks.samples.stacks.alpine

Lifecycle:
  Version: 0.6.1
  Buildpack API: 0.2
  Platform API: 0.2

Run Images:
  cnbs/sample-stack-run:alpine

Buildpacks:
  ID                                          VERSION
  io.buildpacks.samples.java-maven            0.0.1
  io.buildpacks.samples.kotlin-gradle         0.0.1
  io.buildpacks.samples.hello-moon            0.0.1
  io.buildpacks.samples.hello-universe        0.0.1
  io.buildpacks.samples.hello-world           0.0.1

Detection Order:
  Group #1:
    io.buildpacks.samples.java-maven@0.0.1    
  Group #2:
    io.buildpacks.samples.kotlin-gradle@0.0.1    
  Group #3:
    io.buildpacks.samples.hello-universe@0.0.1    

$  ./out/pack build app-02 -B cnbs/sample-builder:alpine -p ~/workspace/samples/apps/java-maven/
...
Successfully built image app-02

Verified it fails with platform API 0.1:

$  ./out/pack inspect-builder platform-01
Inspecting builder: platform-01

REMOTE:
(not present)

LOCAL:

Created By:
  Name: Pack CLI
  Version: dev-2020-02-25-10:15:04

Stack:
  ID: io.buildpacks.samples.stacks.alpine

Lifecycle:
  Version: 0.5.0
  Buildpack API: 0.2
  Platform API: 0.1

Run Images:
  cnbs/sample-stack-run:alpine

Buildpacks:
  ID                                          VERSION
  io.buildpacks.samples.java-maven            0.0.1
  io.buildpacks.samples.kotlin-gradle         0.0.1
  io.buildpacks.samples.hello-universe        0.0.1
  io.buildpacks.samples.hello-moon            0.0.1
  io.buildpacks.samples.hello-world           0.0.1

Detection Order:
  Group #1:
    io.buildpacks.samples.java-maven@0.0.1    
  Group #2:
    io.buildpacks.samples.kotlin-gradle@0.0.1    
  Group #3:
    io.buildpacks.samples.hello-universe@0.0.1    

$  ./out/pack build app-01 -B platform-01 -p ~/workspace/samples/apps/java-maven/
alpine: Pulling from cnbs/sample-stack-run
Digest: sha256:f1bef0812ec1763345774ed6566c6db97893e24aa88e8fd00576c745f17f30cb
Status: Image is up to date for cnbs/sample-stack-run:alpine
ERROR: Builder platform-01 is incompatible with this version of pack

@natalieparellano natalieparellano self-requested a review February 25, 2020 15:48
@jromero jromero added the status/user-accepted Pull Request that has passed user acceptance. label Feb 25, 2020
@jromero jromero merged commit 3738e94 into master Feb 25, 2020
@jromero jromero deleted the feature/507-platform-0.3 branch February 25, 2020 15:48
@jromero jromero added this to the pack-0.9.0 milestone Feb 25, 2020
@hone hone mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalieparellano natalieparellano natalieparellano approved these changes

Assignees
No one assigned
Labels
status/user-accepted Pull Request that has passed user acceptance.
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Add support for Platform API 0.3, drop Platform API 0.1
2 participants
@jromero @natalieparellano