Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v7.5.4 #1188

Merged
merged 47 commits into from
Dec 10, 2020
Merged
Show file tree
Hide file tree
Changes from 46 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
5a8c923
Add Bugsnag-Integrity header to delivery-expo
imjoehaines Nov 18, 2020
9cee021
Ensure the Bugsnag-Integrity header is valid
imjoehaines Nov 13, 2020
10e7b03
Merge pull request #1133 from bugsnag/bugsnag-integrity-header-expo
imjoehaines Nov 19, 2020
b7f5f27
Allow overriding unhandled state in callbacks
imjoehaines Nov 25, 2020
6ff522d
Allow writing to Event.unhandled
imjoehaines Nov 25, 2020
9ab1785
Add assertions for handled states
imjoehaines Nov 25, 2020
47726e7
Add browser tests for overriding unhandled state
imjoehaines Nov 25, 2020
e2fca0c
Add node tests for overriding unhandled state
imjoehaines Nov 25, 2020
eb7a227
Merge branch 'next' into integration/bugsnag-integrity-header
twometresteve Nov 27, 2020
d76c352
Remove session from events that won't be sent
imjoehaines Nov 27, 2020
01fafae
Add changelog entry
imjoehaines Nov 30, 2020
2e556af
Merge pull request #1148 from bugsnag/override-unhandled
bengourley Dec 2, 2020
76104d8
dep: bump bugsnag-android dep to v5.3.0
fractalwrench Dec 2, 2020
11db017
Merge pull request #1164 from bugsnag/bump-android-dep
fractalwrench Dec 2, 2020
4a07fdd
Update npm package name for monorep
loopj Dec 2, 2020
8523e5c
deps(react-native): Bump bugsnag-cocoa to v6.3.0
nickdowell Dec 2, 2020
42b5d2b
Merge pull request #1165 from bugsnag/nickdowell/bugsnag-cocoa-v6.3.0
nickdowell Dec 3, 2020
125d71e
Merge branch 'next' into integration/bugsnag-integrity-header
imjoehaines Dec 3, 2020
395b495
fix(react-native): Fix propagation of enabledReleaseStages from Cocoa…
nickdowell Dec 3, 2020
f91879f
Add changelog entry
imjoehaines Dec 3, 2020
ed29e42
Merge pull request #1167 from bugsnag/readme-fix
bengourley Dec 3, 2020
5133fae
ci(debug): remove VERBOSE in preference to DEBUG
twometresteve Dec 3, 2020
5248e70
Merge pull request #1173 from bugsnag/nickdowell/fix-native-enabled-r…
nickdowell Dec 4, 2020
629c8b8
ci: Reduce browserstack concurrency to 9
fractalwrench Dec 4, 2020
00ec08a
Trial addition of sleep between start and run scenario
twometresteve Dec 4, 2020
14fcc9f
Correct command for Android
twometresteve Dec 4, 2020
c6eaa10
Merge pull request #1175 from bugsnag/tms/remove-verbose
twometresteve Dec 4, 2020
0103cbe
Merge pull request #1176 from bugsnag/reduce-browserstack-concurrency
fractalwrench Dec 4, 2020
e9d730c
Merge pull request #1172 from bugsnag/integration/bugsnag-integrity-h…
imjoehaines Dec 4, 2020
4e95c4c
Increase delay
twometresteve Dec 4, 2020
8b538f8
Add debug
twometresteve Dec 4, 2020
74e4d3e
Merge branch 'next' into tms/code-bundle-id-flake
twometresteve Dec 4, 2020
a36f69c
Leave more time before restarting app
twometresteve Dec 4, 2020
1bb977a
Remove debug
twometresteve Dec 4, 2020
434bb3b
Adjust timing
twometresteve Dec 7, 2020
e925af8
Merge pull request #1177 from bugsnag/tms/code-bundle-id-flake
twometresteve Dec 7, 2020
4f07190
Fix typo
iRayan7 Oct 20, 2020
ef5a1ce
ci(maze-runner): configure enforcement of integrity header
twometresteve Nov 25, 2020
b834d77
Pin Node to MazeRunner v3.6.0
twometresteve Dec 7, 2020
c33e8ea
Only set 3.6.0 config if present
twometresteve Dec 7, 2020
55443da
Merge pull request #1181 from bugsnag/1104-fix-typo
imjoehaines Dec 8, 2020
366a8b9
Correct typo
twometresteve Dec 8, 2020
10004d1
Merge pull request #1182 from bugsnag/tms/maze-3.6.0
twometresteve Dec 9, 2020
ce0d425
dep: update RN android to v5.3.1
fractalwrench Dec 9, 2020
bed0782
Merge pull request #1186 from bugsnag/bump-android
bengourley Dec 9, 2020
043d22b
Release v7.5.4
djskinner Dec 10, 2020
c80f629
chore: update changelog
djskinner Dec 10, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .buildkite/expo-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- --retry=2
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':runner: expo iOS 12'
Expand All @@ -133,7 +133,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- --retry=2
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- block: "Trigger full test suite"
Expand All @@ -155,7 +155,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- --retry=2
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'
soft_fail:
- exit_status: "*"
Expand All @@ -177,7 +177,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- --retry=2
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':runner: expo Android 6'
Expand All @@ -197,7 +197,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- --retry=2
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':runner: expo Android 5'
Expand All @@ -217,7 +217,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- --retry=2
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':runner: expo iOS 11'
Expand All @@ -239,7 +239,7 @@ steps:
- --fail-fast
- --retry=2
- --resilient
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':runner: expo iOS 10'
Expand All @@ -260,5 +260,5 @@ steps:
- --fail-fast
- --retry=2
- --resilient
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'
24 changes: 12 additions & 12 deletions .buildkite/react-native-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ steps:
- --fail-fast
env:
SKIP_NAVIGATION_SCENARIOS: "true"
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':ios: RN 0.60 iOS 12 end-to-end tests'
Expand All @@ -246,7 +246,7 @@ steps:
- --fail-fast
env:
SKIP_NAVIGATION_SCENARIOS: "true"
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':android: RN 0.63 Android 9 end-to-end tests'
Expand All @@ -268,7 +268,7 @@ steps:
- --fail-fast
env:
SKIP_NAVIGATION_SCENARIOS: "true"
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':ios: RN 0.63 iOS 12 end-to-end tests'
Expand All @@ -291,7 +291,7 @@ steps:
- --fail-fast
env:
SKIP_NAVIGATION_SCENARIOS: "true"
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':android: react-navigation 0.60 Android 9 end-to-end tests'
Expand All @@ -312,7 +312,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- features/navigation.feature
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

# See: PLAT-5173
Expand All @@ -336,7 +336,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- features/navigation.feature
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':android: react-navigation 0.63 Android 9 end-to-end tests'
Expand All @@ -357,7 +357,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- features/navigation.feature
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

# See: PLAT-5173
Expand All @@ -381,7 +381,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- features/navigation.feature
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':android: react-native-navigation 0.60 Android 9 end-to-end tests'
Expand All @@ -402,7 +402,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- features/navigation.feature
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

# See: PLAT-5173
Expand All @@ -426,7 +426,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- features/navigation.feature
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':android: react-native-navigation 0.63 Android 9 end-to-end tests'
Expand All @@ -447,7 +447,7 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- features/navigation.feature
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'

# See: PLAT-5173
Expand All @@ -471,5 +471,5 @@ steps:
- --access-key=$BROWSER_STACK_ACCESS_KEY
- --fail-fast
- features/navigation.feature
concurrency: 10
concurrency: 9
concurrency_group: 'browserstack-app'
15 changes: 15 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,25 @@
# Changelog

## v7.5.4 (2020-12-10)

### Changed

- (expo): Add integrity header to verify Error and Session API payloads have not changed. [#1172](/~https://github.com/bugsnag/bugsnag-js/pull/1172)
- (react-native): Update bugsnag-android to v5.3.1
- Add integrity header to verify Error and Session API payloads have not changed. [bugsnag-android#978](/~https://github.com/bugsnag/bugsnag-android/pull/978)
- Prevent potential SHA-1 hash mismatch in Bugsnag-Integrity header [#1028](/~https://github.com/bugsnag/bugsnag-android/pull/1028)
- (react-native): Update bugsnag-cocoa to v6.3.0
- Add integrity header to verify Error and Session API payloads have not changed. [bugsnag-cocoa#881](/~https://github.com/bugsnag/bugsnag-cocoa/pull/881)
- Out Of Memory errors now include more information, including custom metadata and user information. [bugsnag-cocoa#915](/~https://github.com/bugsnag/bugsnag-cocoa/pull/915) [bugsnag-cocoa#908](/~https://github.com/bugsnag/bugsnag-cocoa/pull/908)
- Fixed incorrect app version reported when sending crash reports from older versions of Bugsnag (before 6.2.3) [bugsnag-cocoa#911](/~https://github.com/bugsnag/bugsnag-cocoa/pull/911)
- Fixed a rare crash in -[BugsnagClient computeDidCrashLastLaunch] [bugsnag-cocoa#917](/~https://github.com/bugsnag/bugsnag-cocoa/pull/917)

## v7.5.3 (2020-12-01)

- (react-native): Update bugsnag-cocoa to v6.2.5
- Fixed a rare crash due to a race condition in BugsnagSystemState. [bugsnag-cocoa#893](/~https://github.com/bugsnag/bugsnag-cocoa/pull/893)
- Out Of Memory errors are no longer reported if a device reboot was detected. [bugsnag-cocoa#822](/~https://github.com/bugsnag/bugsnag-cocoa/pull/882)
- (core) The `event.unhandled` flag can now be changed in callbacks [#1148](/~https://github.com/bugsnag/bugsnag-js/pull/1148)

## v7.5.2 (2020-11-09)

Expand Down
2 changes: 1 addition & 1 deletion TESTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ npm run test:build-react-native-ios

Fnd Android:
```shell script
npm run test:build-react-native-ios
npm run test:build-react-native-android
```
These will build a `.ipa` or `.apk` file respectively and copy into `./build`.

Expand Down
6 changes: 0 additions & 6 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ services:
- BUILDKITE_BUILD_NUMBER
command: --fail-fast --retry 2
environment:
VERBOSE:
DEBUG:
BROWSER: "${BROWSER:-chrome_61}"
BROWSER_STACK_USERNAME:
Expand All @@ -55,7 +54,6 @@ services:
NODE_VERSION: "${NODE_VERSION:-10}"
COMPOSE_PROJECT_NAME: "node${NODE_VERSION:-10}"
NETWORK_NAME: "${BUILDKITE_JOB_ID:-js-maze-runner}"
VERBOSE:
DEBUG:
networks:
default:
Expand All @@ -71,7 +69,6 @@ services:
args:
- BUILDKITE_BUILD_NUMBER
environment:
VERBOSE:
DEBUG:
networks:
default:
Expand All @@ -98,7 +95,6 @@ services:
context: .
dockerfile: dockerfiles/Dockerfile.expo-android-builder
environment:
VERBOSE:
DEBUG:
EXPO_USERNAME:
EXPO_PASSWORD:
Expand All @@ -123,7 +119,6 @@ services:
- REG_BASIC_CREDENTIAL
- REG_NPM_EMAIL
environment:
- VERBOSE
- DEBUG
- BRANCH_NAME
- BUILDKITE
Expand All @@ -148,7 +143,6 @@ services:
args:
- BUILDKITE_BUILD_NUMBER
environment:
VERBOSE:
DEBUG:
SKIP_NAVIGATION_SCENARIOS:
networks:
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.node
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ RUN npm pack --verbose packages/plugin-koa/
RUN npm pack --verbose packages/plugin-restify/

# The maze-runner node tests
FROM 855461928731.dkr.ecr.us-west-1.amazonaws.com/maze-runner-releases:latest-v3-cli as node-maze-runner
FROM 855461928731.dkr.ecr.us-west-1.amazonaws.com/maze-runner-releases:v3.5.1-cli as node-maze-runner
WORKDIR /app/
COPY packages/node/ .
COPY test/node test/node
Expand Down
15 changes: 10 additions & 5 deletions packages/core/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -273,11 +273,6 @@ class Client {
event._user = assign({}, event._user, this._user)
event.breadcrumbs = this._breadcrumbs.slice()

if (this._session) {
this._session._track(event)
event._session = this._session
}

// exit early if events should not be sent on the current releaseStage
if (this._config.enabledReleaseStages !== null && !includes(this._config.enabledReleaseStages, this._config.releaseStage)) {
this._logger.warn('Event not sent due to releaseStage/enabledReleaseStages configuration')
Expand Down Expand Up @@ -314,6 +309,16 @@ class Client {
event._handledState.severityReason = { type: 'userCallbackSetSeverity' }
}

if (event.unhandled !== event._handledState.unhandled) {
event._handledState.severityReason.unhandledOverridden = true
event._handledState.unhandled = event.unhandled
}

if (this._session) {
this._session._track(event)
event._session = this._session
}

this._delivery.sendEvent({
apiKey: event.apiKey || this._config.apiKey,
notifier: this._notifier,
Expand Down
24 changes: 24 additions & 0 deletions packages/core/session.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import Session from './types/session'

interface MinimalEvent {
_handledState: {
unhandled: boolean
}
}

interface SessionJson {
id: string
startedAt: Date
events: {
handled: number
unhandled: number
}
}

export default class SessionWithInternals extends Session {
_track(event: MinimalEvent): void
toJSON(): SessionJson

public _handled: number
public _unhandled: number
}
Loading