Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of VERBOSE environment with MazeRunner #1175

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Remove use of VERBOSE environment with MazeRunner #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ services:
- BUILDKITE_BUILD_NUMBER
command: --fail-fast --retry 2
environment:
VERBOSE:
DEBUG:
BROWSER: "${BROWSER:-chrome_61}"
BROWSER_STACK_USERNAME:
Expand All @@ -55,7 +54,6 @@ services:
NODE_VERSION: "${NODE_VERSION:-10}"
COMPOSE_PROJECT_NAME: "node${NODE_VERSION:-10}"
NETWORK_NAME: "${BUILDKITE_JOB_ID:-js-maze-runner}"
VERBOSE:
DEBUG:
networks:
default:
Expand All @@ -71,7 +69,6 @@ services:
args:
- BUILDKITE_BUILD_NUMBER
environment:
VERBOSE:
DEBUG:
networks:
default:
Expand All @@ -98,7 +95,6 @@ services:
context: .
dockerfile: dockerfiles/Dockerfile.expo-android-builder
environment:
VERBOSE:
DEBUG:
EXPO_USERNAME:
EXPO_PASSWORD:
Expand All @@ -123,7 +119,6 @@ services:
- REG_BASIC_CREDENTIAL
- REG_NPM_EMAIL
environment:
- VERBOSE
- DEBUG
- BRANCH_NAME
- BUILDKITE
Expand All @@ -148,7 +143,6 @@ services:
args:
- BUILDKITE_BUILD_NUMBER
environment:
VERBOSE:
DEBUG:
SKIP_NAVIGATION_SCENARIOS:
networks:
Expand Down
2 changes: 1 addition & 1 deletion test/browser/features/support/env.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
FIXTURES_SERVER_PORT = "9020"

# start a web server to serve fixtures
if ENV['VERBOSE']
if ENV['DEBUG']
pid = Process.spawn({"PORT"=>FIXTURES_SERVER_PORT}, 'ruby features/lib/server.rb')
else
DEV_NULL = Gem.win_platform? ? 'NUL' : '/dev/null'
Expand Down