Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress unchecked cast warnings for React Native Android #1027

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Suppress unchecked cast warnings for React Native Android #1027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02e172f
fix: suppress unchecked cast warnings for RN Android
fractalwrench Sep 1, 2020
8332754
Merge branch 'next' into PLAT-4923/suppress-warnings
fractalwrench Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixed

- (react-native): Suppress unchecked cast warnings for React Native Android [#1027](/~https://github.com/bugsnag/bugsnag-js/pull/1027)
- (react-native): Provide proguard rules to ensure reflection works on minified/obfuscated Android builds [#1030](/~https://github.com/bugsnag/bugsnag-js/pull/1030)

## 7.3.3 (2020-08-26)
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/android/src/main/java/com/bugsnag/android/BugsnagReactNative.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ class BugsnagReactNative(private val reactContext: ReactApplicationContext) :
/**
* Serializes a MessageEvent into a WritableMap and sends it across the React Bridge
*/
@Suppress("UNCHECKED_CAST")
fun emitEvent(event: MessageEvent) {
logger.d("Received MessageEvent: ${event.type}")

Expand Down
1 change: 1 addition & 0 deletions packages/react-native/android/src/main/java/com/bugsnag/android/MapExtensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import com.facebook.react.bridge.Arguments
import com.facebook.react.bridge.WritableMap
import com.facebook.react.bridge.WritableNativeMap

@Suppress("UNCHECKED_CAST")
internal fun Map<String, Any?>.toWritableMap(): WritableMap {
val nativeMap = WritableNativeMap()

Expand Down