make setting and clearing of max breadcrumbs static methods #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @wuman - good catch! |
snmaynard
added a commit
that referenced
this pull request
Jul 2, 2015
make setting and clearing of max breadcrumbs static methods
kattrali
added a commit
to bugsnag/bugsnag-unity
that referenced
this pull request
Apr 15, 2016
Android Changelog ==== ## 3.4.0 (2016-03-09) ### Enhancements - Limit the number of stored errors [Duncan Hewett](/~https://github.com/duncanhewett) [#97](bugsnag/bugsnag-android#97) ### Bug Fixes - Fix `ConcurrentModificationException` which could occur when saving breadcrumbs [Duncan Hewett](/~https://github.com/duncanhewett) [#98](bugsnag/bugsnag-android#98) - Localize all numbers in error metrics [Delisa Mason](/~https://github.com/kattrali) [#100](bugsnag/bugsnag-android#100) 3.3.0 (2016-01-18) ----- ### Enhancements - Change distribution method to be .aar only [Lars Grefer](/~https://github.com/larsgrefer) [#91](bugsnag/bugsnag-android#91) - Skip sending empty device data values [Matthias Urhahn](/~https://github.com/d4rken) [#96](bugsnag/bugsnag-android#96) - Remove the need for synthetic methods [Jake Wharton](/~https://github.com/JakeWharton) [#87](bugsnag/bugsnag-android#87) 3.2.7 (2015-12-10) ----- ### Enhancements - Add additional check to ensure the cache of uploaded errors are deleted [#80](bugsnag/bugsnag-android#80) ### Bug Fixes - Fix exception which occurs when `appContext.getResources()` is null [#78](bugsnag/bugsnag-android#78) - Fix bug preventing `maxBreadcrumbs` from being set [David Wu](/~https://github.com/wuman) [#70](bugsnag/bugsnag-android#70) 3.2.6 ----- - Add blocking API - Fix NPE issue - Concurrent adding to tabs - Thread Safe DateUtils#toISO8601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setting and clearing of max breadcrumbs are currently not static methods and hence can never be called. This pull request corrects the error.