Add global metadata to ANR error reports #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-5783/anr-metadata
branch
2 times, most recently
from
12bbbb0 to
52773aa
Compare
Android notifier sizes
Generated by 🚫 Danger |
fractalwrench
force-pushed
the
PLAT-5783/anr-metadata
branch
from
52773aa to
2470b1b
Compare
fractalwrench
force-pushed
the
PLAT-5783/anr-metadata
branch
from
2470b1b to
f0a715d
Compare
tomlongridge
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Ensures that global metadata is added to ANR error reports. These were previously omitted.
Changeset
When creating an event in
NativeInterface, callclient.getMetadataState().getMetadata();to pass into themetadataparameterTesting
Unit test coverage has been updated to mock
client.getMetadataState().getMetadata();where necessary. The ANR smoke scenario has also been updated to confirm that local & global metadata can be added to ANRs.